Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vboot_reference: use the right ar when cross-compiling #69039

Merged
merged 1 commit into from Sep 19, 2019

Conversation

samueldr
Copy link
Member

Motivation for this change

Allow cross-compilation of vboot_reference.

The Makefile from upstream chromeos doesn't allow setting or using AR to refer to the right ar.

An alternative fix would be to make a proper patch, but the patch would more likely need to be updated on updating the package.

Things done
  • ✔️ Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • ✔️ NixOS
    • ☑️ macOS
    • ☑️ other Linux distributions
  • ☑️ Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • ✔️ Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • ✔️ Tested execution of all binary files (usually in ./result/bin/)
  • ☑️ Determined the impact on package closure size (by running nix path-info -S before and after)
  • ✔️ Ensured that relevant documentation is up to date
  • ✔️ Fits CONTRIBUTING.md.
Notify maintainers

cc @thefloweringash

@ofborg ofborg bot requested a review from lheckemann September 18, 2019 19:30
@matthewbauer matthewbauer merged commit ca99e45 into NixOS:master Sep 19, 2019
@samueldr samueldr deleted the cross/vboot_reference branch September 19, 2019 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants