Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdeFrameworks: 5.61.0 -> 5.62.0 #68910

Merged
merged 12 commits into from Sep 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 16, 2019

Motivation for this change

https://kde.org/announcements/kde-frameworks-5.62.0.php

Things done

Tested this for the portion I use on my laptop, not sure if we have any
more exhaustive tests/targets?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ttuegel

@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

cc @nyanloutre too :).

@ttuegel
Copy link
Member

ttuegel commented Sep 17, 2019

@GrahamcOfBorg test plasma5

@ttuegel
Copy link
Member

ttuegel commented Sep 18, 2019

Apparently I no longer have the magic touch. I will have to test this locally and report back.

Copy link
Contributor

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@worldofpeace
Copy link
Contributor

@ttuegel I believe ofborg is still on the fritz in terms of building things.

@ttuegel
Copy link
Member

ttuegel commented Sep 18, 2019

I believe ofborg is still on the fritz in terms of building things.

Ah, I didn't know that. Thanks! I will defer to @bkchr on this one.

@dtzWill Could you please rebase this onto staging?

@ttuegel
Copy link
Member

ttuegel commented Sep 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants