Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.certifi: 2019.6.16 -> 2019.9.11 #69040

Merged
merged 1 commit into from
Oct 22, 2019
Merged

pythonPackages.certifi: 2019.6.16 -> 2019.9.11 #69040

merged 1 commit into from
Oct 22, 2019
+2 −2

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Noticed it was out of date when I got an error with a pip install

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner September 18, 2019 19:35
@jonringer
Copy link
Contributor Author

this should be moved to staging to avoid hydra rebuilds... I'll open a new one when im not so tired

@jonringer
pythonPackages.certifi: 2019.6.16 -> 2019.9.11

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jonringer Jonathan Ringer
GPG key ID: 5C841D3CFDFEC4E0
Expired
Verified
Learn about vigilant mode
acb114b
@jonringer jonringer changed the base branch from master to staging October 3, 2019 09:25
@jonringer
Copy link
Contributor Author

@FRidh rebased on top of staging. Should be good to merge now :)

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment labels Oct 3, 2019
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild 8.has: clean-up 8.has: package (new) This PR adds a new package and removed 6.topic: printing 6.topic: qt/kde 6.topic: stdenv Standard environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild labels Oct 3, 2019
@FRidh FRidh merged commit ba8e617 into NixOS:staging Oct 22, 2019
@jonringer jonringer deleted the bump-certifi branch October 22, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh