Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dropbox: 73.4.118 -> 81.4.195 #69108

Merged
merged 1 commit into from Sep 21, 2019
Merged

dropbox: 73.4.118 -> 81.4.195 #69108

merged 1 commit into from Sep 21, 2019

Conversation

srghma
Copy link
Contributor

@srghma srghma commented Sep 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from ttuegel September 19, 2019 17:43
@peterhoeg
Copy link
Member

There is no point updating this unless the earlier version can no longer be found as dropbox will update itself after installation.

You can also have a look at maestral as an open-source alternative to the dropbox client.

@peterhoeg peterhoeg closed this Sep 20, 2019
@srghma
Copy link
Contributor Author

srghma commented Sep 20, 2019 •
edited

Weird but dropbox start -i didn't want to upgrade until I made this change

And there is point in upgrading because following your logic there is less probability that newer version will be deleted and no longer be found

@peterhoeg
Copy link
Member

peterhoeg commented Sep 20, 2019 via email

@srghma
Copy link
Contributor Author

srghma commented Sep 21, 2019 •
edited

If you've already verified that it works, we might as well merge it

Yes, let's merge it, I don't want to verify is it really that client was updated because nixpkg was updated or it was just a fluke, let's merge it just in case

@peterhoeg peterhoeg reopened this Sep 21, 2019
@Mic92 Mic92 merged commit 2f261c9 into NixOS:master Sep 21, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

[detached HEAD 564a4c6] dropbox: 73.4.118 -> 81.4.195
Author: Serhii Khoma srghma@gmail.com
Date: Thu Sep 19 20:26:50 2019 +0300
1 file changed, 1 insertion(+), 1 deletion(-)

@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

[detached HEAD 55724ce] dropbox: 63.4.107 -> 73.4.118
Author: Langston Barrett langston.barrett@gmail.com
Date: Sun May 26 10:34:09 2019 -0700
1 file changed, 1 insertion(+), 1 deletion(-)
[detached HEAD 73aec98] dropbox: 73.4.118 -> 81.4.195
Author: Serhii Khoma srghma@gmail.com
Date: Thu Sep 19 20:26:50 2019 +0300
1 file changed, 1 insertion(+), 1 deletion(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srghma @peterhoeg @Mic92