Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] Touchups for nixos/xfce4-14 #69109

Merged
merged 5 commits into from Sep 21, 2019
Merged

[19.09] Touchups for nixos/xfce4-14 #69109

merged 5 commits into from Sep 21, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
xfceUnstable: make an alias
2e8d263 
To be removed with xfce4-12.

(cherry picked from commit a8167d1)
@worldofpeace
nixos/xfce4-14: remove gtk-xfce-engine
57d5f08 
Xfce 4.14 deprecated this.
It had many gtk2 themes that don't work that confused users NixOS#68977.

(cherry picked from commit 5bcec76)
@worldofpeace
nixos/xfce4-14: add gnome-themes-extra
0667602 
(cherry picked from commit f85e126)
@worldofpeace
nixos/xfce4-14: cleanup defaults slightly
ac71ccf 
We added
- parole
- pavucontrol
- xfce4-taskmanager
- xfwm4-themes

to the default packages.

(cherry picked from commit f6398d8)
@worldofpeace
fixup! nixos/xfce4-14: cleanup defaults slightly
22f4e6e 
(cherry picked from commit 0b73294)
@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 19, 2019
@worldofpeace worldofpeace added this to the 19.09 milestone Sep 19, 2019
@worldofpeace worldofpeace merged commit 47d6531 into NixOS:release-19.09 Sep 21, 2019
@worldofpeace worldofpeace deleted the backport-xfce branch September 21, 2019 03:27
@worldofpeace
Copy link
Contributor Author

bah, fixup commit 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: xfce The Xfce Desktop Environment 8.has: clean-up 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace