This is the same source code as pythonPackages.trezor_agent do you mind integrating it from there and while at it, make the trezor-agent as the same way?

And probably keepkey while we are at it, for consistency.

This is the same source code as pythonPackages.trezor_agent do you mind integrating it from there and while at it, make the trezor-agent as the same way?

Thanks for the feedback and pointer to the existing pythonPackages.trezor_agent, which I somehow didn't notice, @mmahut! As you say, that package uses the same https://github.com/romanz/trezor-agent source code as is used in this PR in the ledger_agent.

I'll rephrase your suggestion to make sure I understood; is the aim to have a pythonPackages.trezor_agent define a single python package, that can be referenced in three top-level packages as follows?

• pkgs/applications/misc/ledgeragent
• pkgs/applications/misc/trezoragent
• pkgs/applications/misc/keepkeyagent

I don't have Trezor or Keepkey devices accessible right now, so I can't fully test those changes, but if that's what you were suggesting I can make that change and we can hold off on merging until we can test the change fully.

Also, do you (and/or @np?) want to be added as a maintainer to these top-level packages? (I'm fine not being a maintainer too btw, depending on your preference, just put myself there in this PR to get things started.)

I'll rephrase your suggestion to make sure I understood; is the aim to have a pythonPackages.trezor_agent define a single python package, that can be referenced in three top-level packages as follows?

That is correct.

I don't have Trezor or Keepkey devices accessible right now, so I can't fully test those changes, but if that's what you were suggesting I can make that change and we can hold off on merging until we can test the change fully.

I think I can help with testing.

Also, do you (and/or @np?) want to be added as a maintainer to these top-level packages? (I'm fine not being a maintainer too btw, depending on your preference, just put myself there in this PR to get things started.)

Sure, yes, please. More maintainers the better :)

Thanks for the feedback @mmahut @worldofpeace, please take another look.

I'll rephrase your suggestion to make sure I understood; is the aim to have a pythonPackages.trezor_agent define a single python package, that can be referenced in three top-level packages as follows?

That is correct.

I couldn't figure out a way to achieve what you suggested here..

The issue is that the buildPythonPackage definition uses fetchPyPi to pull down the specific library, one of the ones below depending on which package we're building:

• https://pypi.org/project/trezor-agent/: 0.10.0
• https://pypi.org/project/ledger_agent/: 0.9.0
• https://pypi.org/project/keepkey_agent/: 0.9.0

Because the top-level packages now are just using with python3Packages; toPythonApplication foo_agent; (thanks for the suggestion @worldofpeace), I don't see how to avoid having three python packages for the three pip projects we want to pull down.

As an aside, the listed versions above are the latest that have been published, but at https://github.com/romanz/trezor-agent the latest published version is 0.13.1.

cc @romanz, would it be possible to publish the latest release to pypi.org as well?

Also, do you (and/or @np?) want to be added as a maintainer to these top-level packages? (I'm fine not being a maintainer too btw, depending on your preference, just put myself there in this PR to get things started.)

Sure, yes, please. More maintainers the better :)

Cool, I've added the two of you and myself (hkjn mmahut np) to all three packages:

• trezor_agent
• ledger_agent
• keepkey_agent

cc @romanz, would it be possible to publish the latest release to pypi.org as well?

The latest versions of specific agents' packages should be on PyPI, albeit under different versions than the libagent package (which contains the common library code).
For example, https://pypi.org/project/trezor-agent/ has 0.10.0 - which is the latest TREZOR agent release (see agents/trezor/setup.py).

Please let me know if I can fix the versioning to be more consistent and easier to follow :)

cc @romanz, would it be possible to publish the latest release to pypi.org as well?

The latest versions of specific agents' packages should be on PyPI, albeit under different versions than the libagent package (which contains the common library code).
For example, https://pypi.org/project/trezor-agent/ has 0.10.0 - which is the latest TREZOR agent release (see agents/trezor/setup.py).

Please let me know if I can fix the versioning to be more consistent and easier to follow :)

Ah, that versioning scheme makes sense, given that all four releaseable units (three agents + libagent) are in the same repo.

I guess my confusion came from the repo being named trezor-agent, but containing the code for all four releases. Perhaps we can add a note to either the Github releases for the repo, or the README.md? (I can send a PR, let's continue there.)

This looks good to me, @worldofpeace might confirm is there is a better way to do this.

@1000101 might help with ledger/keepkey testing.

Sorry, this felt off my radar. I will try to get it tested with real hardware.

Thanks for the review, @jonringer!

Let me know if anyone has any remaining comments that have not been addressed, or otherwise how to progress with getting this PR merged.

awesome, I'll look into rebasing my trezor gpg agent module on this now