Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ledgerblue: 0.1.24 -> 0.1.28 #69152

Merged
merged 1 commit into from Sep 21, 2019
Merged

pythonPackages.ledgerblue: 0.1.24 -> 0.1.28 #69152

merged 1 commit into from Sep 21, 2019

Conversation

hkjn
Copy link
Contributor

@hkjn hkjn commented Sep 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @np

@hkjn hkjn requested a review from FRidh as a code owner September 20, 2019 12:04
@ofborg ofborg bot requested a review from np September 20, 2019 12:19
jonringer
jonringer approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
leaf package

@worldofpeace
Copy link
Contributor

@hkjn, I've changed your commit msg to use the pythonPackages attribute because it's preferred for it to be an actual attribute.

@worldofpeace worldofpeace changed the title python: ledgerblue: 0.1.24 -> 0.1.28 pythonPackages.ledgerblue: 0.1.24 -> 0.1.28 Sep 21, 2019
@worldofpeace worldofpeace merged commit b952f5d into NixOS:master Sep 21, 2019
@hkjn
Copy link
Contributor Author

hkjn commented Sep 22, 2019

@hkjn, I've changed your commit msg to use the pythonPackages attribute because it's preferred for it to be an actual attribute.

Thanks @worldofpeace! I'll keep that in mind for future PRs touching pythonPackages.

@hkjn hkjn deleted the 20190920-bump-ledgerblue branch September 22, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hkjn @worldofpeace @jonringer