Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hcloud: init at 1.6.1 #69151

Merged
merged 2 commits into from Oct 3, 2019
Merged

pythonPackages.hcloud: init at 1.6.1 #69151

merged 2 commits into from Oct 3, 2019

Conversation

liff
Copy link
Contributor

@liff liff commented Sep 20, 2019 •
edited

Motivation for this change

Add this Python package: https://pypi.org/project/hcloud

As well as being useful for Python scripts that use the hcloud API it is also used by Ansible’s ‘hcloud’ cloud module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@liff liff requested a review from FRidh as a code owner September 20, 2019 12:02
@liff liff force-pushed the add/pythonPackages.hcloud branch 2 times, most recently from 7050443 to 0f563f6 Compare October 2, 2019 09:28
@liff liff changed the title pythonPackages.hcloud: init at 1.6.0 pythonPackages.hcloud: init at 1.6.1 Oct 2, 2019
jonringer
jonringer approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (1 minor suggestion)
outputs LGTM
leaf package

[4 built, 3 copied (0.5 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69151
2 package were build:
python27Packages.hcloud python37Packages.hcloud

pkgs/development/python-modules/hcloud/default.nix Outdated Show resolved Hide resolved
@liff
Copy link
Contributor Author

liff commented Oct 3, 2019

Thank you for the review. Removed tox.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.hcloud python37Packages.hcloud

@jonringer
Copy link
Contributor

can you squash the hcloud commits into one? https://nixos.org/nixpkgs/manual/#submitting-changes-hotfixing-pull-requests

@liff liff force-pushed the add/pythonPackages.hcloud branch from b4fbc7a to 38594e7 Compare October 3, 2019 08:31
@liff
Copy link
Contributor Author

liff commented Oct 3, 2019

Rebased, sorry about that.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.hcloud python37Packages.hcloud

@jonringer
Copy link
Contributor

previous review still stands :) Thanks for your work.

@jonringer jonringer merged commit 2ac643c into NixOS:master Oct 3, 2019
@liff liff mentioned this pull request Oct 14, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liff @jonringer