Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nm-tray: init at 0.4.3 #69059

Merged
merged 1 commit into from Feb 18, 2020
Merged

nm-tray: init at 0.4.3 #69059

merged 1 commit into from Feb 18, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 18, 2019

Motivation for this change

"Simple Network Manager frontend written in Qt"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Sep 19, 2019

Tested in nix-review, it worked but had no icon ? I am using i3

QSystemTrayIcon::setVisible: No Icon set
nm-tray: starting connection editor  ("xterm", "-e", "nmtui-edit")
nm-tray: connection editor  ("xterm", "-e", "nmtui-edit")  finished, exitCode= 0 , exitStatus= QProcess::NormalExit

@mmahut
Copy link
Member

mmahut commented Sep 19, 2019

@GrahamcOfBorg build nm-tray

@dtzWill
Copy link
Member Author

dtzWill commented Oct 7, 2019

Not sure what to do re:icon, works here-- but I think it's picking up from my active icon theme (papirus).

@teto teto merged commit bdcee48 into NixOS:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @teto @mmahut