Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 6c3bf80a75ba
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 27994da3185d
Choose a head ref
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on Sep 7, 2019

  1. squashfsTools: 4.4dev_20180612 -> 4.4

    A new release has been made upstream. Reproducibility issues were fixed
    in that release, so we no longer need those patches. For a full overview
    of the changes, see the 4.4-specific readme at [1].
    
    The alignment patch no longer applies cleanly; I disabled it for now,
    and I will try to restore it in a follow-up commit.
    
    [1]: https://github.com/plougher/squashfs-tools/blob/52eb4c279cd283ed9802dd1ceb686560b22ffb67/README-4.4
    ruuda committed Sep 7, 2019
    Copy the full SHA
    442cf4f View commit details
    Browse the repository at this point in the history
  2. squashfsTools: make alignment patch apply to 4.4

    I took the patch, and applied it on top of the previous squashfs-tools
    commit that we packaged (which required editing one line in the patch,
    as it assumed to be applied on top of the reproducibility patches). Then
    I rebased that on top of master, resolved one conflict, and I formatted
    a new patch for this.
    ruuda committed Sep 7, 2019
    Copy the full SHA
    a60ee9a View commit details
    Browse the repository at this point in the history
  3. squashfsTools: make Darwin patch apply to 4.4

    I took the patch, and applied it on top of the previous squashfs-tools
    commit that we packaged. It applied cleanly. Then I rebased that on top
    of master, and resolved the conflicts. I'm not sure I resolved them
    correctly though, I don't have access to Darwin. Somebody needs to
    review this.
    ruuda committed Sep 7, 2019
    Copy the full SHA
    14d2c36 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. squashfsTools: use updated Darwin patch

    This new patch is the patch between 4.4, and commit [1], a pull request
    at [2] to upsteam Mac and BSD compatibility. That pull request is
    itself a rebase of an older pull request for an earlier version of
    squashfs-tools. I squashed all commits between 4.4 and [1], apart from
    the BSD-specific ones, and exported the new patch from that. Attached
    below is the git diff --ignore-space-change between squashfs-tools 4.4
    with the previous patch applied, and with the new patch applied.
    
    [1]: 7d31beec53e6245d3405d6ef2b96e9811ae07044
    [2]: plougher/squashfs-tools#69
    
    ---
    
    diff --git a/squashfs-tools/info.c b/squashfs-tools/info.c
    index 8efefe6..5c2f835 100644
    --- a/squashfs-tools/info.c
    +++ b/squashfs-tools/info.c
    @@ -159,7 +159,7 @@ void *info_thrd(void *arg)
     			case EINTR:
     				continue;
     			default:
    -				BAD_ERROR("sigwaitfailed "
    +				BAD_ERROR("sigwait failed "
     					"because %s\n", strerror(errno));
     			}
     		}
    diff --git a/squashfs-tools/mksquashfs.c b/squashfs-tools/mksquashfs.c
    index 67d86a5..3607448 100644
    --- a/squashfs-tools/mksquashfs.c
    +++ b/squashfs-tools/mksquashfs.c
    @@ -35,7 +35,10 @@
     #include <stddef.h>
     #include <sys/types.h>
     #include <sys/stat.h>
    -#ifdef linux
    +#ifndef linux
    +#include <sys/sysctl.h>
    +#else
    +#include <sys/sysinfo.h>
     #include <sys/sysmacros.h>
     #endif
     #include <fcntl.h>
    @@ -52,7 +55,6 @@
     #include <sys/wait.h>
     #include <limits.h>
     #include <ctype.h>
    -#include <sys/sysinfo.h>
    
     #ifndef FNM_EXTMATCH /* glibc extension */
     	#define FNM_EXTMATCH 0
    @@ -5191,7 +5193,17 @@ int parse_mode(char *arg, mode_t *res)
    
     int get_physical_memory()
     {
    +	/*
    +	 * Long longs are used here because with PAE, a 32-bit
    +	 * machine can have more than 4GB of physical memory
    +	 *
    +	 * sysconf(_SC_PHYS_PAGES) relies on /proc being mounted.
    +	 * If it fails use sysinfo, if that fails return 0
    +	 */
    +	long long num_pages = sysconf(_SC_PHYS_PAGES);
    +	long long page_size = sysconf(_SC_PAGESIZE);
     	int phys_mem;
    +
     #ifndef linux
     	#ifdef HW_MEMSIZE
     		#define SYSCTL_PHYSMEM HW_MEMSIZE
    @@ -5221,16 +5233,6 @@ int get_physical_memory()
     	}
       #undef SYSCTL_PHYSMEM
     #else
    -	/*
    -	 * Long longs are used here because with PAE, a 32-bit
    -	 * machine can have more than 4GB of physical memory
    -	 *
    -	 * sysconf(_SC_PHYS_PAGES) relies on /proc being mounted.
    -	 * If it fails use sysinfo, if that fails return 0
    -	 */
    -	long long num_pages = sysconf(_SC_PHYS_PAGES);
    -	long long page_size = sysconf(_SC_PAGESIZE);
    -
     	if(num_pages == -1 || page_size == -1) {
     		struct sysinfo sys;
     		int res = sysinfo(&sys);
    diff --git a/squashfs-tools/mksquashfs.h b/squashfs-tools/mksquashfs.h
    index 88d0b5c..1beefef 100644
    --- a/squashfs-tools/mksquashfs.h
    +++ b/squashfs-tools/mksquashfs.h
    @@ -24,7 +24,6 @@
      * mksquashfs.h
      *
      */
    -#include <pthread.h>
    
     struct dir_info {
     	char			*pathname;
    diff --git a/squashfs-tools/pseudo.c b/squashfs-tools/pseudo.c
    index f8fd529..48e6b27 100644
    --- a/squashfs-tools/pseudo.c
    +++ b/squashfs-tools/pseudo.c
    @@ -30,7 +30,6 @@
     #include <errno.h>
     #include <string.h>
     #include <stdlib.h>
    -#include <sys/stat.h>
     #include <sys/types.h>
     #include <sys/wait.h>
     #include <sys/stat.h>
    diff --git a/squashfs-tools/unsquashfs.c b/squashfs-tools/unsquashfs.c
    index 00615ce..c1a6183 100644
    --- a/squashfs-tools/unsquashfs.c
    +++ b/squashfs-tools/unsquashfs.c
    @@ -38,7 +38,6 @@
     #include <sys/sysinfo.h>
     #include <sys/sysmacros.h>
     #endif
    -
     #include <sys/types.h>
     #include <sys/time.h>
     #include <sys/resource.h>
    @@ -1085,7 +1084,7 @@ int create_inode(char *pathname, struct inode *i)
     			break;
     		case SQUASHFS_SYMLINK_TYPE:
     		case SQUASHFS_LSYMLINK_TYPE: {
    -			struct timespec times[2] = {
    +			struct timeval times[2] = {
     				{ i->time, 0 },
     				{ i->time, 0 }
     			};
    @@ -1104,8 +1103,7 @@ int create_inode(char *pathname, struct inode *i)
     				goto failed;
     			}
    
    -			res = utimensat(AT_FDCWD, pathname, times,
    -					AT_SYMLINK_NOFOLLOW);
    +			res = lutimes(pathname, times);
     			if(res == -1) {
     				EXIT_UNSQUASH_STRICT("create_inode: failed to set time on "
     					"%s, because %s\n", pathname,
    ruuda committed Sep 10, 2019
    Copy the full SHA
    f6e8ee7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. squashfsTools: 4.4dev_20180612 -> 4.4 (#68275)

    squashfsTools: 4.4dev_20180612 -> 4.4
    Mic92 committed Sep 20, 2019
    Copy the full SHA
    27994da View commit details
    Browse the repository at this point in the history