New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
argo: 2.2.1 -> 2.3.0 #69139
argo: 2.2.1 -> 2.3.0 #69139
Conversation
bump version and sha in default.nix
update deps.nix by running dep2nix on argo:release-2.3 source
@thundergolfer Did you test this locally? |
I get an build error, when trying to build this: @GrahamcOfBorg build argo |
Confirm that
I'm not familiar with this codebase so will need to take a bit of time to look into it. |
The problem is still present in |
Just a wild speculation: Did you run go2nix against master of argo or against the released version? Might be an incompatible dependency version. |
@Mic92 No it ran I've since discovered that bumping I'll stick up a PR on argoproj/argo for that, but don't know why this is happening. |
argo 2.4.0 has been released and it fixes the build issue. nixpkgs bump here: |
Closing in favour of #70672 |
Motivation for this change
Make Argo's
2.3.0
available in Nixpkgs.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @groodt