Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argo: 2.2.1 -> 2.3.0 #69139

Closed
wants to merge 2 commits into from
Closed

argo: 2.2.1 -> 2.3.0 #69139

wants to merge 2 commits into from

Conversation

thundergolfer
Copy link

@thundergolfer thundergolfer commented Sep 20, 2019

Motivation for this change

Make Argo's 2.3.0 available in Nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @groodt

Jonathon Belotti added 2 commits September 20, 2019 17:06
bump version and sha in default.nix
update deps.nix by running dep2nix on argo:release-2.3 source
@groodt
Copy link
Contributor

groodt commented Sep 21, 2019

@thundergolfer
Can you change the title of the PR to: argo: 2.2.1 -> 2.3.0

Did you test this locally?

@thundergolfer thundergolfer changed the title Upgrade argo to 2.3.0 from 2.2.1 argo: 2.2.1 -> 2.3.0 Sep 22, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 22, 2019

I get an build error, when trying to build this:
argo.log

@GrahamcOfBorg build argo

@thundergolfer
Copy link
Author

@Mic92

Confirm that cd $(git rev-parse --show-toplevel) && nix-build -A argo is showing me the same error:

go/src/github.com/argoproj/argo/workflow/artifacts/hdfs/util.go:21:26: cannot use krbClient (type *"gopkg.in/jcmturner/gokrb5.v5/client".Client) as type *"github.com/colinmarc/hdfs/vendor/gopkg.in/jcmturner/gokrb5.v5/client".Client in assignment
builder for '/nix/store/wfpzhnc91l4mdk4jxz37y743nqqhpbhk-argo-2.3.0.drv' failed with exit code 1

I'm not familiar with this codebase so will need to take a bit of time to look into it.

@thundergolfer
Copy link
Author

The problem is still present in 2.4.0-rc1.

@Mic92
Copy link
Member

Mic92 commented Sep 23, 2019

Just a wild speculation: Did you run go2nix against master of argo or against the released version? Might be an incompatible dependency version.

@thundergolfer
Copy link
Author

@Mic92 No it ran dep2nix, and ran it on the correct branch.

I've since discovered that bumping colinmarc/hdfs in the Gopkg.toml to the next commit, which no longer vendors deps, fixes the issue.

I'll stick up a PR on argoproj/argo for that, but don't know why this is happening.

@groodt
Copy link
Contributor

groodt commented Oct 7, 2019

argo 2.4.0 has been released and it fixes the build issue. nixpkgs bump here:
#70672

@thundergolfer
Copy link
Author

Closing in favour of #70672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants