Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pymupdf: init at 1.16.2 #69085

Merged
merged 1 commit into from Sep 27, 2019
Merged

pythonPackages.pymupdf: init at 1.16.2 #69085

merged 1 commit into from Sep 27, 2019

Conversation

teto
Copy link
Member

@teto teto commented Sep 19, 2019

python bindings for mupdf. Provides the fitz module for
https://github.com/dsanson/termpdf.py that I am trying to package.

NB: when packaging termpdf.py (https://github.com/teto/home/blob/master/config/nixpkgs/overlays/pkgs/termpdf/default.nix), it can't import fitz
and looking at the .termpdf.py wrapper, I found the addition (sys.argv[0]...), is that normal ?

import sys;import site;import functools;sys.argv[0] = '/nix/store/j7aifx4jh1crvj90l93khrzk7llwzqrr-termpdf.py-0.1.1/bin/termpdf.py';functools.reduce(lambda k, p: site.addsitedir(p, k), ['/nix/store/j7aifx4jh1crvj90l93khrzk7llwzqrr-termpdf.py-0.1.1/lib/python3.7/site-packages','/nix/store/i50wf0cg1l46y4l7x41waypliiapfmry-python3.7-setuptools-41.0.1/lib/python3.7/site-packages'], site._init_pathinfo());
__version__ = "0.1.1"
__license__ = "MIT"
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
Copy link
Member Author

teto commented Sep 23, 2019

@jonringer I authorize you to test your new superpowers (once and if you get them) on this PR ;)

@teto
Copy link
Member Author

teto commented Sep 27, 2019

@GrahamcOfBorg build pythonPackages.pymudpf

@jonringer
Copy link
Contributor

unfortunately still no super powers :(

@teto
Copy link
Member Author

teto commented Sep 27, 2019

@GrahamcOfBorg build pythonPackages.pymupdf

python bindings for mupdf. Provides the fitz module for
https://github.com/dsanson/termpdf.py that I am trying to package.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (upstream doesn't have tests)
leaf package

@teto
Copy link
Member Author

teto commented Sep 27, 2019

@GrahamcOfBorg build pythonPackages.pymupdf

@teto teto merged commit afd6b04 into NixOS:master Sep 27, 2019
@teto teto deleted the pymupdf branch September 27, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants