Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt 5.12.4 #69086

Merged
merged 9 commits into from Sep 26, 2019
Merged

Qt 5.12.4 #69086

merged 9 commits into from Sep 26, 2019

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 19, 2019 •
edited

Motivation for this change

This pull request updates Qt 5.12.3 to Qt 5.12.4, including several long-awaited bug fixes. There is a newer long-term support patch-level release, but I don't have it working yet, nor do I have Qt 5.13 working. This is working on NixOS, but it is still broken on macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ttuegel ttuegel self-assigned this Sep 19, 2019
@ofborg ofborg bot requested review from bkchr, periklis and qknight September 19, 2019 10:23
@ttuegel ttuegel changed the base branch from master to staging September 19, 2019 12:39
@ttuegel
Copy link
Member Author

ttuegel commented Sep 21, 2019

This should be fixed on macOS now.

@ttuegel ttuegel marked this pull request as ready for review September 21, 2019 11:11
@ttuegel ttuegel merged commit a2e3bef into NixOS:staging Sep 26, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 30, 2019
@ttuegel @dtzWill
Merge pull request NixOS#69086 from ttuegel/qt-5.12.4
a90b1f7 
Qt 5.12.4

(cherry picked from commit a2e3bef)
@shatsky shatsky mentioned this pull request Apr 30, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr Awaiting requested review from bkchr

@periklis periklis Awaiting requested review from periklis

@qknight qknight Awaiting requested review from qknight

Assignees

@ttuegel ttuegel

Labels
6.topic: qt/kde 8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @vcunat