treewide: build some unfree packages locally #68627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfree packages aren't distributed by our binary cache due to legal reasons[1] and are usually a prebuilt binary that requires some patching. When using distributed builds[2], those are uploaded to another build machine as fixed-output derivations from `fetchurl` are built locally[3] which takes a certain amount of time and resources with almost no gain as the build process is trivial in contrast to the up/download to a remote builder. This is why I figured that at least some of the packages should be explicitly built locally, I've done something simlar for `citrix_workspace` already in the past[4]. The following packages are affected by this: * `idea.*` (excluding free derivatives) * `xmind` * `teamviewer` [1] https://nixos.wiki/wiki/FAQ/How_can_I_install_a_proprietary_or_unfree_package%3F#More_precision [2] https://nixos.wiki/wiki/Distributed_build [3] https://github.com/NixOS/nixpkgs/blob/267c8d6b2fea05bc811c8e2c2f4529b1436eeb9a/pkgs/build-support/fetchurl/default.nix#L95 [4] 87f818d
|
Merging for now. Got a thumbs up from a commiter and as this only affects unfree packages I don't think that this will affect our binary caches negatively. |
|
@volth doesn't it still try to substitute the source archives from the local private cache, and then the build phase should take not much more time than unpacking a NAR? If yes, I think this is better made explicit. |
|
Perhaps it deserves to be marked with own flag, or bot-maintained `(build time) / (download time)` value so the builder could be better informed making local vs. remote decisions.
I would say that `preferLocalBuild` is such a flag. The change was updating a few unfree packages where it made sense to set it; in general that flag gets set either for binary packages (and being binary is highly correlated with being unfree, thus the wording), or for really trivial builders.
Keeping a good track of build time could be useful for many things, but nobody has invested sufficient effort to make it happen yet.
|
|
But then all JetBrains packages should have `preferLocalBuild`.
Probably so. I guess this flag is added whenever someone is annoyed enough by something they use…
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unfree packages aren't distributed by our binary cache due to legal
reasons[1] and are usually a prebuilt binary that requires some patching.
When using distributed builds[2], those are uploaded to another build
machine as fixed-output derivations from
fetchurlare built locally[3]which takes a certain amount of time and resources with almost no gain
as the build process is trivial in contrast to the up/download to a
remote builder.
This is why I figured that at least some of the packages should be
explicitly built locally, I've done something simlar for
citrix_workspacealready in the past[4].The following packages are affected by this:
idea.*(excluding free derivatives)xmindteamviewer[1] https://nixos.wiki/wiki/FAQ/How_can_I_install_a_proprietary_or_unfree_package%3F#More_precision
[2] https://nixos.wiki/wiki/Distributed_build
[3]
nixpkgs/pkgs/build-support/fetchurl/default.nix
Line 95 in 267c8d6
[4] 87f818d
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @