Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_9: init #69115

Merged
merged 10 commits into from Sep 29, 2019
Merged

llvmPackages_9: init #69115

merged 10 commits into from Sep 29, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 19, 2019

Motivation for this change

https://lists.llvm.org/pipermail/llvm-dev/2019-September/135304.html

Woohoo! Help testing appreciated, thanks!

I'm rebuilding it on this tree presently, will update
as builds come in :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
llvmPackages_9: copy llvmPackages_8
9552213
@dtzWill
llvmPackages_9: hashes, pname-ification
99eeff0
@dtzWill
top-level: add llvmPackages_9 and the usual variants
75b5ac3 
* Bump llvmPackages_latest to llvmPackages_9,
  since it's the latest ;)
* Leave llvmPackages = llvmPackages_7.... for now.
@ofborg ofborg bot requested review from lovek323 and 7c6f434c September 19, 2019 19:00
@dtzWill
Copy link
Member Author

dtzWill commented Sep 19, 2019

@GrahamcOfBorg build clang_9 llvm_9 lld_9 lldb_9
@GrahamcOfBorg build pkgsMusl.clang_9 pkgsMusl.llvm_9 pkgsMusl.lld_9 pkgsMusl.lldb_9
@GrahamcOfBorg build tests.cc-wrapper-clang-9 tests.cc-wrapper-libcxx-9
@GrahamcOfBorg build pkgsMusl.tests.cc-wrapper-clang-9 pkgsMusl.tests.cc-wrapper-libcxx-9
#GoGoGadgetBorgBot
@GrahamcOfBorg botsnack ❤️

@dtzWill
Copy link
Member Author

dtzWill commented Sep 19, 2019

Working on LLDB presently, FWIW.

Also, there was the relicensing[1] from the mostly-NCSA/UIUC to "Apache 2.0 with LLVM Exception" (see [1] for details). This may not be the first release after the change, so let's check and update our expressions accordingly :).

[1] https://llvm.org/foundation/relicensing/

@jonringer
Copy link
Contributor

can't download a lot of the links

Failure log 
builder for '/nix/store/pm4naksvhdggbjn4l62qdnxcl8fv6sbb-cfe-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/cfe-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download cfe-9.0.0.src.tar.xz from any mirror
builder for '/nix/store/4mjdbcn3s1r9wqayvpd7ywhb75rzj47v-llvm-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/llvm-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download llvm-9.0.0.src.tar.xz from any mirror
builder for '/nix/store/xax1kbs5wxfpn4ngf1c3jy1kcjv8w80j-lld-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/lld-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download lld-9.0.0.src.tar.xz from any mirror
builder for '/nix/store/720jscfncmzlh0zpinsmf4rkpbp3i78c-clang-tools-extra-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/clang-tools-extra-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download clang-tools-extra-9.0.0.src.tar.xz from any mirror
builder for '/nix/store/mr6k78dw52p598j07zd5cq9nbr51bxhh-lldb-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/lldb-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download lldb-9.0.0.src.tar.xz from any mirror
builder for '/nix/store/whdz3xbxvkhs650lanbcib6vcmdd2g64-polly-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/polly-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download polly-9.0.0.src.tar.xz from any mirror
cannot build derivation '/nix/store/icl94z46bbn8cp8pqbviymfj558dza7j-llvm-9.0.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/p120slawyzljrmidn9h0nw1ivh97sb38-llvm-9.0.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/m3m5jpv752anqsmi5mma9layj777aq4z-clang-9.0.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/pa0alk1w78ksfj4jibh4p72p2al112m3-clang-9.0.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/brd7kw88rgirlz52ggdip378dd1bz3bf-lld-9.0.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0hfqr7xfxaw25x38hvs74jr9bj40z5bk-clang-tools-9.0.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wbapi6h8aykn08kldww7dmyp8gifpjg1-lldb-9.0.0.drv': 3 dependencies couldn't be built
builder for '/nix/store/g4cdcldknxqpk3jkb9c1iknwkp3wfjpr-compiler-rt-9.0.0.src.tar.xz.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/llvm/llvm-project/releases/download/llvmorg-9.0.0/compiler-rt-9.0.0.src.tar.xz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download compiler-rt-9.0.0.src.tar.xz from any mirror
cannot build derivation '/nix/store/jy49m8m50z27jm5x96w5c1l2cvsh0qp7-compiler-rt-9.0.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5i6hd21ksk7xdywcqvrwrnasdijjlv38-clang-wrapper-9.0.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/5j7gl9p5sgn07zivpz2liv00zkj3bp3q-clang-wrapper-9.0.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/7lnfh5109lqxnfd9m43xqrwikjk7laah-env.drv': 7 dependencies couldn't be built
[0 built (7 failed), 0.0 MiB DL]

@dtzWill
Copy link
Member Author

dtzWill commented Sep 19, 2019

can't download a lot of the links

Whoops! I thought the github URL's were working (and preferred), but apparently they're not up ("yet"). Should be fixed now, thanks!

@dtzWill
Copy link
Member Author

dtzWill commented Sep 21, 2019

Patched test, will be sending upstream once confirm our builders vet that it does indeed fix it :). And the first time I don't test any of the rc's, too! That'll show me :P.

@nomeata nomeata mentioned this pull request Sep 21, 2019
Merged
nomeata added a commit to dfinity/motoko that referenced this pull request Sep 21, 2019
@nomeata
Try upgrading to llvm9 as released
a8a509a 
based on NixOS/nixpkgs#69115
@nomeata nomeata mentioned this pull request Sep 21, 2019
Merged
vcunat
vcunat approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix code seems good, and whole llvmPackages_9 builds for me on x86_64. I tested the compiler by building a few projects with it, and mesa-19.2.0 with llvm_9. I believe we can defer further improvement to later.

vcunat added a commit that referenced this pull request Sep 29, 2019
@vcunat
Merge #69115: llvmPackages_9: init
de99e7c
@vcunat vcunat merged commit 233ba40 into NixOS:master Sep 29, 2019
@arcnmx arcnmx mentioned this pull request Sep 30, 2019
Merged
10 tasks
mergify bot pushed a commit to dfinity/motoko that referenced this pull request Nov 12, 2019
@nomeata @mergify
Upgrade to llvm9 as released (#677)
ef8d4ca 
based on NixOS/nixpkgs#69115

The trick is to use `--target=wasm32-unknown-emscripten-wasm`, the LLVM works just fine.
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
Merged
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @jonringer @vcunat