Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static override for libressl #69107

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@matthewbauer matthewbauer changed the title Add static override for libresl Add static override for libressl Sep 19, 2019
@ofborg ofborg bot requested review from fpletz and thoughtpolice September 19, 2019 16:51
Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to cause a regression with foundationdb packages

builder for '/nix/store/2kibrdq27v1w7sl1fv2v33rgr5frwvci-foundationdb-5.1.7.drv' failed with exit code 2; last 10 log lines:
                                                                                               ^
  fdbserver/QuietDatabase.actor.cpp:237:96: warning: format '%lld' expects argument of type 'long long int*', but argument 3 has type 'int64_t* {aka long int*}' [-Wformat=]
      sscanf(extractAttribute(movingDataMessage.toString(), "InFlight").c_str(), "%lld", &inFlight);
                                                                                                  ^
  g++: internal compiler error: Killed (program cc1plus)
  Please submit a full bug report,
  with preprocessed source if appropriate.
  See <http://gcc.gnu.org/bugs.html> for instructions.
  make: *** [fdbserver/generated.mk:71: .objs/fdbserver/DataDistribution.actor.g.cpp.o] Error 4
  make: *** Waiting for unfinished jobs....
cannot build derivation '/nix/store/haka4q6g1hrz3026y1iyhi4yx6mxrhff-python2.7-foundationdb-5.1.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x2h5zr5v8nqk6l5dymd2hbqk96kaqs9n-python3.7-foundationdb-5.1.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dljglz5i71ga4dqrvy94sbj6qghk7p3m-env.drv': 3 dependencies couldn't be built
[28 built (1 failed), 3 copied (3.8 MiB), 1.2 MiB DL]
error: build of '/nix/store/dljglz5i71ga4dqrvy94sbj6qghk7p3m-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69107
3 package failed to build:
foundationdb51 python27Packages.foundationdb51 python37Packages.foundationdb51

@matthewbauer matthewbauer merged commit c2092f6 into NixOS:master Oct 15, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants