Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do-agent: init at 3.5.6 #69186

Merged
merged 9 commits into from
Oct 2, 2019
Merged

do-agent: init at 3.5.6 #69186

merged 9 commits into from
Oct 2, 2019
+76 −0

Conversation

yvt
Copy link
Member

@yvt yvt commented Sep 21, 2019 •
edited
Loading

Motivation for this change

This agent program is needed for DigitalOcean's monitoring panel and alert feature to work. It’s highly useful for those who use NixOS on DO droplets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

yvt added 3 commits September 21, 2019 13:15
@yvt
maintainer: Add yvt
a5deef6
@yvt
do-agent: init at 3.5.6
5ef5852
@yvt
nixos/do-agent: init

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
832ede6
@yvt yvt requested a review from infinisil as a code owner September 21, 2019 04:28
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels Sep 21, 2019
@ofborg ofborg bot requested a review from kalbasit September 21, 2019 04:43
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 21, 2019
yvt added 2 commits September 23, 2019 17:23
@yvt
do-agent: Use pname instead of name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
74e1d47
@yvt
nixos/do-agent: Update description

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
1745ab3
@yvt yvt requested a review from alexarice September 24, 2019 07:39
@alexarice
Copy link
Contributor

@GrahamcOfBorg build do-agent

@alexarice
Copy link
Contributor

Should this work on aarch?

@yvt
do-agent: Fix modSha256

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
4fd8034
@yvt
Copy link
Member Author

yvt commented Sep 24, 2019

It should theoretically work on AArch64, too, though DO doesn't provide Arm-based droplets at this moment.

@alexarice
Copy link
Contributor

@GrahamcOfBorg build do-agent

alexarice
alexarice approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds with nix-review though I can't really comment on the module

@Kiwi
Copy link
Member

Kiwi commented Sep 24, 2019

The module is working for me with defaults at least. Thanks!

infinisil
infinisil requested changes Sep 27, 2019
View reviewed changes
yvt added 3 commits October 3, 2019 01:09
@yvt
maintainer: Set githubId of yvt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b1acc7d
@yvt
nixos/do-agent: Use DynamicUser

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e3c1ecf
@yvt
nixos/do-agent: Depend on network-online.target
00a5420
@yvt yvt requested a review from infinisil October 2, 2019 17:47
infinisil
infinisil approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, tested it with my DO droplet, working well, thanks for the PR!

@infinisil infinisil merged commit 643a329 into NixOS:master Oct 2, 2019
@infinisil
Copy link
Member

Ah whoops, should've squashed the commits a bit, oh well

@infinisil infinisil mentioned this pull request Oct 2, 2019
Merged
10 tasks
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice

@infinisil infinisil

@kalbasit kalbasit

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yvt @alexarice @Kiwi @infinisil @Janik-Haag