Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages_5_3.openafs_1_8: fix build #69161

Merged
merged 1 commit into from Sep 20, 2019

Conversation

artemist
Copy link
Member

This update cherry-picks patches necessary to build the OpenAFS kernel
module from the OpenAFS master branch. This commit does not fix OpenAFS
1.6.

Motivation for this change

OpenAFS failed to build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @spacefrogg @maggesi

This update cherry-picks patches necessary to build the OpenAFS kernel
module from the OpenAFS master branch. This commit does not fix OpenAFS
1.6.
@veprbl
Copy link
Member

veprbl commented Sep 20, 2019

@GrahamcOfBorg build linuxPackages_5_3.openafs_1_8

@artemist
Copy link
Member Author

artemist commented Sep 20, 2019

We might as well check older versions of Linux (I haven't checked yet)
@GrahamcOfBorg build linuxPackages_4_4.openafs_1_8 linuxPackages.openafs_1_8
Hopefully I'm not hammering our servers too much

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on x86_64-linux (non-NixOS without sandboxing)

3 package failed to build:
linuxPackages_hardened.openafs_1_8 linuxPackages_latest_hardened.openafs_1_8 linuxPackages_testing_hardened.openafs_1_8

11 package were build:
linuxPackages-libre.openafs_1_8 linuxPackages.openafs_1_8 linuxPackages_4_14.openafs_1_8 linuxPackages_4_4.openafs_1_8 linuxPackages_4_9.openafs_1_8 linuxPackages_5_2.openafs_1_8 linuxPackages_5_3.openafs_1_8 linuxPackages_latest-libre.openafs_1_8 linuxPackages_latest_xen_dom0.openafs_1_8 linuxPackages_testing_bcachefs.openafs_1_8 linuxPackages_xen_dom0.openafs_1_8

@veprbl veprbl merged commit 55d63ef into NixOS:master Sep 20, 2019
@spacefrogg
Copy link
Contributor

@artemist @veprbl Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants