Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
base: 91ef2f58e3ba
Choose a base ref
...
head repository: m-labs/nmigen
compare: a1bc2bbeb044
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Sep 20, 2019

  1. hdl.mem: use 1 as reset value for ReadPort.en.

    This is necessary for consistency, since for transparent read ports,
    we currently do not support .en at all (it is fixed at 1) due to
    YosysHQ/yosys#760. Before this commit, changing port transparency
    would require adding or removing an assignment to .en, which is
    confusing and error-prone.
    
    Also, most read ports are always enabled, so this behavior is also
    convenient.
    whitequark committed Sep 20, 2019
    Copy the full SHA
    4b3a068 View commit details
    Browse the repository at this point in the history
  2. lib.fifo: work around Yosys issue with handling of \TRANSPARENT.

    Because of YosysHQ/yosys#1390, using a transparent port in AsyncFIFO,
    instead of being a no-op (as the semantics of \TRANSPARENT would
    require it to be in this case), results in a failure to infer BRAM.
    
    This can be easily avoided by using a non-transparent port instead,
    which produces the desirable result with Yosys. It does not affect
    the semantics on Xilinx platforms, since the interaction between
    the two ports in case of address collision is undefined in either
    transparent (WRITE_FIRST) or non-transparent (READ_FIRST) case, and
    the data out of the write port is not used at all.
    
    Fixes #172.
    whitequark committed Sep 20, 2019
    Copy the full SHA
    f9b9c17 View commit details
    Browse the repository at this point in the history
  3. lib.fifo: fix doc typo. NFC.

    whitequark committed Sep 20, 2019
    Copy the full SHA
    a1bc2bb View commit details
    Browse the repository at this point in the history