Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.h11: fix darwin build #68681

Merged
merged 1 commit into from Sep 20, 2019
Merged

pythonPackages.h11: fix darwin build #68681

merged 1 commit into from Sep 20, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 13, 2019

Motivation for this change

The h11 python package includes some tests that require localhost access and thus fail on macOS. This issue stayed unnoticed in #67896 since I just recently setup macOS testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@B4dM4n B4dM4n requested a review from FRidh as a code owner September 13, 2019 16:11
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 13, 2019
@B4dM4n B4dM4n mentioned this pull request Sep 13, 2019
Merged
10 tasks
@matthewbauer
Copy link
Member

@GrahamcOfBorg build pythonPackages.h11

@LnL7 LnL7 merged commit a6dcdf9 into NixOS:master Sep 20, 2019
@B4dM4n B4dM4n deleted the h11-darwin branch September 20, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @matthewbauer @LnL7