Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.17.0 -> 0.18.0 #69164

Merged
merged 1 commit into from Sep 21, 2019
Merged

starship: 0.17.0 -> 0.18.0 #69164

merged 1 commit into from Sep 21, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nix path-info -S /nix/store/330r48k36kxzggcdlk10qj3xa9986yb1-starship-0.17.0
/nix/store/330r48k36kxzggcdlk10qj3xa9986yb1-starship-0.17.0 32152272

nix path-info -S /nix/store/kh5wm43v1747kmz2xjmhvpvpjgpxj58z-starship-0.18.0
/nix/store/kh5wm43v1747kmz2xjmhvpvpjgpxj58z-starship-0.18.0 32217304

openssl is no longuer needed

@marsam marsam merged commit 3cd425f into NixOS:master Sep 21, 2019
@marsam
Copy link
Contributor

marsam commented Sep 21, 2019

Thanks!

@bbigras bbigras deleted the starship branch September 21, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @marsam