Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wine 4.16, Winetricks 20190615 #68774

Merged
merged 2 commits into from Sep 19, 2019
Merged

Wine 4.16, Winetricks 20190615 #68774

merged 2 commits into from Sep 19, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@veprbl
Copy link
Member

veprbl commented Sep 16, 2019

@GrahamcOfBorg build winetricks winePackages.unstable winePackages.staging

veprbl
veprbl approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review on x86_64-linux

1 package failed to build:
pipelight

10 package were build:
lutris lutris-free lutris-unwrapped protontricks wine-staging winePackages.staging winePackages.unstable wineWowPackages.staging wineWowPackages.unstable winetricks

@veprbl veprbl merged commit 916d7b5 into NixOS:master Sep 19, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 19, 2019
@veprbl @dtzWill
Merge pull request NixOS#68774 from tadeokondrak/wine-4.16-winetricks…
3f79a66 
…-20190615

Wine 4.16, Winetricks 20190615

(cherry picked from commit 916d7b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadeokondrak @veprbl