Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NetBeans 11.1 #69124

Merged
merged 3 commits into from Oct 21, 2019
Merged

Update to NetBeans 11.1 #69124

merged 3 commits into from Oct 21, 2019

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Sep 19, 2019

Motivation for this change

Updated NetBeans to 11.1 which contains several new features and bugfixes (http://netbeans.apache.org/download/nb111/index.html).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[demo@nixos:~/dev/nix/nixpkgs]$ nix-shell -p nix-review --run "nix-review rev b10b7d07908"
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Total 7 (delta 5), reused 7 (delta 5), pack-reused 0
Unpacking objects: 100% (7/7), done.
From https://github.com/NixOS/nixpkgs
   8dbca5e3ca4..889537352b5  master     -> refs/nix-review/0
$ git worktree add /home/demo/.cache/nix-review/rev-b10b7d07908327fe00ac698646d9871790c07e8e/nixpkgs 889537352b5e208017dad66dd51b3923b7f2d23f
Preparing worktree (detached HEAD 889537352b5)
Checking out files: 100% (19839/19839), done.
HEAD is now at 889537352b5 h2o: 2.2.6 -> 2.3.0-beta2, enable multi-output
$ nix-env -f /home/demo/.cache/nix-review/rev-b10b7d07908327fe00ac698646d9871790c07e8e/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit b10b7d07908327fe00ac698646d9871790c07e8e
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/demo/.cache/nix-review/rev-b10b7d07908327fe00ac698646d9871790c07e8e/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/demo/.cache/nix-review/rev-b10b7d07908327fe00ac698646d9871790c07e8e/build.nix
[4 built, 131 copied (682.4 MiB), 157.4 MiB DL]
1 package were build:
netbeans

[0.0 MiB DL]
$ nix-shell /home/demo/.cache/nix-review/rev-b10b7d07908327fe00ac698646d9871790c07e8e/shell.nix
these paths will be fetched (1.51 MiB download, 8.27 MiB unpacked):
  /nix/store/jpmqrdn1jsghfhf6pndfq0mk17654d57-bash-interactive-4.4-p23-info
  /nix/store/lqg80z4wdkkwszkw6cwmazywvk9kvzvd-bash-interactive-4.4-p23-doc
  /nix/store/r9y9gg5lbsdgaxmhp6idl0k556l0x9hs-readline-7.0p5
  /nix/store/s9l4454hlkrbj5fd5yv1dr9xz1daqswj-bash-interactive-4.4-p23
  /nix/store/v4a4366hrmrwhg55fbq6fz39qvww56qg-bash-interactive-4.4-p23-man
  /nix/store/w4bin8lakab76zmcvixql3x77w7329zs-bash-interactive-4.4-p23-dev
copying path '/nix/store/lqg80z4wdkkwszkw6cwmazywvk9kvzvd-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/jpmqrdn1jsghfhf6pndfq0mk17654d57-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/v4a4366hrmrwhg55fbq6fz39qvww56qg-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/r9y9gg5lbsdgaxmhp6idl0k556l0x9hs-readline-7.0p5' from 'https://cache.nixos.org'...
copying path '/nix/store/s9l4454hlkrbj5fd5yv1dr9xz1daqswj-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/w4bin8lakab76zmcvixql3x77w7329zs-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @svanderburg @rszibele

Copy link
Contributor

@rszibele rszibele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@asbachb
Copy link
Contributor Author

asbachb commented Sep 29, 2019

@rszibele @svanderburg Is there anything preventing this from merging?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/70

@fpletz fpletz merged commit a2638b6 into NixOS:master Oct 21, 2019
@asbachb asbachb deleted the update-to-netbeans-11.1 branch June 13, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants