Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: remove dontStrip from derivation #69155

Merged
merged 1 commit into from Sep 22, 2019
Merged

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Sep 20, 2019

Motivation for this change

This was introduced in 2010 in 9e16b81 and as far as I can tell the
issue mentioned in the comment does not exist anymore. In a stripped
mono build, I was able to:

  • Run "mcs --version" without trouble (original test case)
  • Run "keepass" (mono app)
  • Build packages that depend on mono (e.g. f# and others).

$ nix path-info -sh
Before: 537.8M
After: 304.3M

$ nix path-info -Sh
Before: 1.2G
After: 867.0M

(Transitive closure size decreases more than the package size itself
because mono ended up depending on gcc through leaked paths in .so files
before.)

Part of #69146

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice @obadz @vrthra

This was introduced in 2010 in 9e16b81 and as far as I can tell the
issue mentioned in the comment does not exist anymore. In a stripped
mono build, I was able to:

- Run "mcs --version" without trouble (original test case)
- Run "keepass" (mono app)
- Build packages that depend on mono (e.g. f# and others).

$ nix path-info -sh
Before: 537.8M
After:  304.3M

$ nix path-info -Sh
Before: 1.2G
After:  867.0M

(Transitive closure size decreases more than the package size itself
because mono ended up depending on gcc through leaked paths in .so files
before.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants