Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix libcanberra-gtk{2,3} on Darwin #69111

Merged
merged 1 commit into from Sep 25, 2019
Merged

Fix libcanberra-gtk{2,3} on Darwin #69111

merged 1 commit into from Sep 25, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Ran into #61891 (comment) on darwin.
Apparently #61912 was not enough to fix it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @smaret

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 19, 2019
@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build libcanberra-gtk2 libcanberra-gtk3

jtojnar
jtojnar approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have no other option since it hard depends on X even on Mac.

@LnL7
Copy link
Member

LnL7 commented Sep 20, 2019

This is better, but the libraries still don't build.

#include <gdk/gdkx.h>
         ^~~~~~~~~~~~
1 error generated.
make[2]: *** [Makefile:1326: libcanberra_gtk3_module_la-canberra-gtk-module.lo] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-libcanberra-0.30.drv-1/libcanberra-0.30/src'
make[1]: *** [Makefile:546: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-libcanberra-0.30.drv-1/libcanberra-0.30'
make: *** [Makefile:408: all] Error 2
builder for '/nix/store/m9zc6warkdhjnhc7pfs80c3nsscim2dj-libcanberra-0.30.drv' failed with exit code 2
error: build of '/nix/store/m9zc6warkdhjnhc7pfs80c3nsscim2dj-libcanberra-0.30.drv' failed

@rvolosatovs
Copy link
Member Author

Which one is this? both libcanberra-gtk2 and libcanberra-gtk3 succeeded for me on Darwin

@LnL7
Copy link
Member

LnL7 commented Sep 20, 2019

Only checked the gtk3 variant, libcanberra-gtk2 does indeed work now.

@matthewbauer matthewbauer merged commit 11497a8 into NixOS:master Sep 25, 2019
@rvolosatovs rvolosatovs deleted the fix/libcanberra-gtk branch September 6, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @LnL7 @jtojnar @matthewbauer