New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: add mesonpep517 as build system #72784
Conversation
|
||
propagatedNativeBuildInputs = [ meson ninja ]; | ||
|
||
# This should be propagated as long as meson comes with a hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am starting to get an increasing dislike of packages including a setup hook when you do not want it. Maybe we should split it off, that is into a meson
and mesonHook
.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/trouble-building-passwordsafe-a-meson-python-gtk3-package/4652/6 |
meta = { | ||
description = "Create pep517 compliant packages from the meson build system"; | ||
homepage = https://gitlab.com/thiblahute/mesonpep517; | ||
license = lib.licenses.asl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect license
We will need to patch this to support multiple outputs: |
, pythonOlder | ||
}: | ||
|
||
# TODO: offer meson as a Python package so we have dist-info folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's silly, actually. We need it is as a Python package if packages start adding it as a build system requirement. However, it should not be needed considering meson is only an application; they do not actually import it.
2cf41d6
to
2efbf4f
Compare
@GrahamcOfBorg build python3.pkgs.mesonpep517 |
Add meson as Python package so it can easily be used by mesonpep517 for PEP 517 builds.
Motivation for this change
I would like to demonstrate mesonpep517 and thus choose to upstream it.
While it "works", I am not very happy with this yet. See e.g. the comments in the code.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @