Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add mesonpep517 as build system #72784

Merged
merged 3 commits into from Nov 5, 2019
Merged

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 4, 2019

Motivation for this change

I would like to demonstrate mesonpep517 and thus choose to upstream it.

While it "works", I am not very happy with this yet. See e.g. the comments in the code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @


propagatedNativeBuildInputs = [ meson ninja ];

# This should be propagated as long as meson comes with a hook.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am starting to get an increasing dislike of packages including a setup hook when you do not want it. Maybe we should split it off, that is into a meson and mesonHook.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/trouble-building-passwordsafe-a-meson-python-gtk3-package/4652/6

meta = {
description = "Create pep517 compliant packages from the meson build system";
homepage = https://gitlab.com/thiblahute/mesonpep517;
license = lib.licenses.asl;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect license

@jtojnar
Copy link
Contributor

jtojnar commented Nov 4, 2019

, pythonOlder
}:

# TODO: offer meson as a Python package so we have dist-info folder.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's silly, actually. We need it is as a Python package if packages start adding it as a build system requirement. However, it should not be needed considering meson is only an application; they do not actually import it.

@FRidh
Copy link
Member Author

FRidh commented Nov 5, 2019

@GrahamcOfBorg build python3.pkgs.mesonpep517

Add meson as Python package so it can easily be used by mesonpep517 for
PEP 517 builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants