[css-grid] Grid align justify tests #20088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[css-pseudo] Implement parsing for ::marker pseudo-element
wpt-pr-bot
requested review from
fantasai,
javifernandez,
mrego,
plinss,
rachelandrew,
svillar and
tabatkins
|
|
||
| <div> | ||
| <p>border: 5px 10px 15px 20px | padding: 10px 15px 20px 30px | margin: 4px 8px 12px 16px<br> | ||
| direction: LTR (ortho) | align-items: 'self-start' | justify-items: 'self-start'</p> |
There was a problem hiding this comment.
The purpose of the 'self-start' value is to use the flow direction (either inline-flow or block-flow) of the child, instead of the container's one. In this case, we are using the same block-flow direction for children (vertical-lr, inherited from the container) but we are changing the chidlren's inline-flow direction (RTL).
This is why we are getting different results for the CSS property controlling the inline-axis (or column-axis, since we are testing a grid layout case), which is the justify-self property. Note that align-items: self-start provides the same behavior than align-item: start.
So, I think it could be a good idea to clarify this in the text above the test case, so that we can understand the test results and why the test case is rendered this way. Maybe something like this:
direction: LTR (ortho) | align-items: 'self-start' (vertical-lr)| justify-items: 'self-start' (RTL)
I think the term (ortho) in the direction tries to add such information, but I think it's not clear enough; what do you think ?
There was a problem hiding this comment.
Being the subject a bit complicated, it is surely a good idea to give some clearer info in the explanatory
. I will change it accordingly where needed, here and in the vertical-rl file, and push a new commit.
javifernandez
approved these changes
Nov 7, 2019
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 8, 2020
The alignment tests in question have been moved from WebKit to WPT with the following PR: * #19828 * #20088 * #19809 * #19665 * #20110 The removed tests that are now in WPT can be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch removes the outdated version of the tests from third_party/blink/web_tests/fast/css-grid-layout/ Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 8, 2020
The alignment tests in question have been moved from WebKit to WPT with the following PR: * #19828 * #20088 * #19809 * #19665 * #20110 The removed tests that are now in WPT can be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch removes the outdated version of the tests from third_party/blink/web_tests/fast/css-grid-layout/ Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729346}
pull bot
pushed a commit
to tkntjsdw/wpt
that referenced
this pull request
Jan 8, 2020
The alignment tests in question have been moved from WebKit to WPT with the following PR: * web-platform-tests#19828 * web-platform-tests#20088 * web-platform-tests#19809 * web-platform-tests#19665 * web-platform-tests#20110 The removed tests that are now in WPT can be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch removes the outdated version of the tests from third_party/blink/web_tests/fast/css-grid-layout/ Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729346}
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Jan 8, 2020
The alignment tests in question have been moved from WebKit to WPT with the following PR: * web-platform-tests/wpt#19828 * web-platform-tests/wpt#20088 * web-platform-tests/wpt#19809 * web-platform-tests/wpt#19665 * web-platform-tests/wpt#20110 The removed tests that are now in WPT can be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch removes the outdated version of the tests from third_party/blink/web_tests/fast/css-grid-layout/ Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729346}
LukeZielinski
pushed a commit
that referenced
this pull request
Jan 8, 2020
The alignment tests in question have been moved from WebKit to WPT with the following PR: * #19828 * #20088 * #19809 * #19665 * #20110 The removed tests that are now in WPT can be found under: third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ This patch removes the outdated version of the tests from third_party/blink/web_tests/fast/css-grid-layout/ Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729346} Co-authored-by: _Ros_ <rmonteriso@igalia.com>
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 9, 2020
This reverts commit 514a76b7b6287b8e34d200cf51e666d3ee32e511. Reason for revert: This was removing the tests from the wrong location, it was removing them from WPT folder instead of fast/css-grid-layout/. Original change's description: > [css-grid] Remove outdated css-grid-layout alignment tests > > The alignment tests in question have been moved from WebKit to WPT > with the following PR: > * #19828 > * #20088 > * #19809 > * #19665 > * #20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 9, 2020
This reverts commit 514a76b7b6287b8e34d200cf51e666d3ee32e511. Reason for revert: This was removing the tests from the wrong location, it was removing them from WPT folder instead of fast/css-grid-layout/. Original change's description: > [css-grid] Remove outdated css-grid-layout alignment tests > > The alignment tests in question have been moved from WebKit to WPT > with the following PR: > * #19828 > * #20088 > * #19809 > * #19665 > * #20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729932}
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jan 9, 2020
This reverts commit 514a76b7b6287b8e34d200cf51e666d3ee32e511. Reason for revert: This was removing the tests from the wrong location, it was removing them from WPT folder instead of fast/css-grid-layout/. Original change's description: > [css-grid] Remove outdated css-grid-layout alignment tests > > The alignment tests in question have been moved from WebKit to WPT > with the following PR: > * #19828 > * #20088 > * #19809 > * #19665 > * #20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729932}
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Jan 9, 2020
This reverts commit 514a76b. Reason for revert: This was removing the tests from the wrong location, it was removing them from WPT folder instead of fast/css-grid-layout/. Original change's description: > [css-grid] Remove outdated css-grid-layout alignment tests > > The alignment tests in question have been moved from WebKit to WPT > with the following PR: > * web-platform-tests/wpt#19828 > * web-platform-tests/wpt#20088 > * web-platform-tests/wpt#19809 > * web-platform-tests/wpt#19665 > * web-platform-tests/wpt#20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729932}
pull bot
pushed a commit
to FreddyZeng/chromium
that referenced
this pull request
Jan 14, 2020
This is a reland of 514a76b Original change's description: > The alignment tests in question have been moved from WebKit to WPT with the following PR: > * web-platform-tests/wpt#19828 > * web-platform-tests/wpt#20088 > * web-platform-tests/wpt#19809 > * web-platform-tests/wpt#19665 > * web-platform-tests/wpt#20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} Change-Id: Icce03111d6107929510fcafcf061c02dcc846cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997105 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#731350}
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jan 20, 2020
…rid-layout alignment tests", a=testonly Automatic update from web-platform-tests Revert "[css-grid] Remove outdated css-grid-layout alignment tests" This reverts commit 514a76b7b6287b8e34d200cf51e666d3ee32e511. Reason for revert: This was removing the tests from the wrong location, it was removing them from WPT folder instead of fast/css-grid-layout/. Original change's description: > [css-grid] Remove outdated css-grid-layout alignment tests > > The alignment tests in question have been moved from WebKit to WPT > with the following PR: > * web-platform-tests/wpt#19828 > * web-platform-tests/wpt#20088 > * web-platform-tests/wpt#19809 > * web-platform-tests/wpt#19665 > * web-platform-tests/wpt#20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729932} -- wpt-commits: 2a73e37c60b18846d9d2798c845242f209d74644 wpt-pr: 21120
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 21, 2020
…rid-layout alignment tests", a=testonly Automatic update from web-platform-tests Revert "[css-grid] Remove outdated css-grid-layout alignment tests" This reverts commit 514a76b7b6287b8e34d200cf51e666d3ee32e511. Reason for revert: This was removing the tests from the wrong location, it was removing them from WPT folder instead of fast/css-grid-layout/. Original change's description: > [css-grid] Remove outdated css-grid-layout alignment tests > > The alignment tests in question have been moved from WebKit to WPT > with the following PR: > * web-platform-tests/wpt#19828 > * web-platform-tests/wpt#20088 > * web-platform-tests/wpt#19809 > * web-platform-tests/wpt#19665 > * web-platform-tests/wpt#20110 > > The removed tests that are now in WPT can be found under: > third_party/blink/web_tests/external/wpt/css/css-grid/alignment/ > > This patch removes the outdated version of the tests from > third_party/blink/web_tests/fast/css-grid-layout/ > > Change-Id: I2e5601700332b8fb2e12036f9c45ae7e98bf90b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989531 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#729346} TBR=jfernandez@igalia.com,rego@igalia.com,obrufau@igalia.com,rmonteriso@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I18d98894d82e9800024d0fd23ee11c82432a0e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993801 Reviewed-by: Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#729932} -- wpt-commits: 2a73e37c60b18846d9d2798c845242f209d74644 wpt-pr: 21120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that the following properties for CSS grid are correctly working for align and justify: