Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7783, #7816: SDL2: Fix various issues with keyboard input #7825

Merged
merged 6 commits into from Nov 10, 2019

Conversation

JGRennison
Copy link
Contributor

SDL2:

@nielsmh
Copy link
Contributor

nielsmh commented Nov 5, 2019

The commit checker wants commit message form Fix #7783, Fix #7816: SDL2: Fix input handling in edit context

I think the SDL2 part in messages should also be bracketed, so [SDL2] not SDL2:.

SDL_Keysym::scancode is a SDL_SCANCODE_* constant, not a raw scan code
SDLK_PAGEUP and SDLK_PAGEDOWN are not sequential
They must have separate entries in _vk_mapping
SDL_Keysym::sym is not suitable for checking whether the character
is printable or not
… context

In particular this fixes handling of the shift key
@JGRennison JGRennison force-pushed the fix-sdl2-keyboard-input-issues branch from 0728dc5 to 41ae84e Compare November 5, 2019 18:19
@LordAro LordAro merged commit a15ace0 into OpenTTD:master Nov 10, 2019
@JGRennison JGRennison deleted the fix-sdl2-keyboard-input-issues branch January 9, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants