Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/stdenv.xml: wrapProgram buildInput requirement #71074

Closed
wants to merge 1 commit into from
Closed

doc/stdenv.xml: wrapProgram buildInput requirement #71074

wants to merge 1 commit into from

Conversation

SRGOM
Copy link
Member

@SRGOM SRGOM commented Oct 13, 2019

Added buildInput requirement for wrapProgram, fixes #57792.

Please comment for improvement or discard if not appropriate for inclusion.

Added `buildInput` requirement for `wrapProgram`, fixes #57792.
@flokli
Copy link
Contributor

flokli commented Oct 13, 2019

makeWrapper would be a nativeBuildInput.

But I think the paragraph before that

The standard environment provides a number of useful functions

is already confusing - it'd suggest it should already be available.

@worldofpeace, WDTY?

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 13, 2019

It's confusing because people might think wrapProgram is a separate thing when it all comes from makeWrapper. I might've made the mistake of trying to add wrapProgram to nativeBuildInputs way back, so it is confusing. We just need a comment explaining that wrapProgram is a convenience function also provided by the makeWrapper "package".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nixpkgs-manual] wrapProgram needs clarification about required build input
3 participants