Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibre: bugfix: add markdown to inputs #72726

Merged

Conversation

bennyandresen
Copy link
Contributor

fixes #72724

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @pSub @AndersonTorres

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds. Trace looks like it needs it.

@worldofpeace worldofpeace merged commit 7daa6ec into NixOS:master Nov 3, 2019
@worldofpeace
Copy link
Contributor

Not sure if this needs a backport on 19.09.

One could run the executable off of that channel like

nix run -f channel:nixos-19.09 calibre -c calibre

and see if markdown things are working.

@bennyandresen
Copy link
Contributor Author

Not sure if this needs a backport on 19.09.

One could run the executable off of that channel like

nix run -f channel:nixos-19.09 calibre -c calibre

and see if markdown things are working.

@worldofpeace a backport to 19.09 is needed.

this fails:

nix run -f channel:nixos-19.09 calibre -c calibre

this works:

nix run -I ~/Projects/NixOS/ nixpkgs.calibre -c calibre

@worldofpeace
Copy link
Contributor

Not sure if this needs a backport on 19.09.
One could run the executable off of that channel like

nix run -f channel:nixos-19.09 calibre -c calibre

and see if markdown things are working.

@worldofpeace a backport to 19.09 is needed.

this fails:

nix run -f channel:nixos-19.09 calibre -c calibre

this works:

nix run -I ~/Projects/NixOS/ nixpkgs.calibre -c calibre

Thanks for checking. I've backported it in 6c2f097.

@bennyandresen bennyandresen deleted the calibre_bugfix_addmarkdown branch November 20, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calibre: will crash if markdown is configured in custom column
2 participants