dcpj1100dw-cups: init at 1.0.5-0 #72758
Closed
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike past Brother drivers, this contains binaries which reference absolute /opt paths. I could have added an rpath hack to override syscalls like stat but I decided the driver should just run in a simple FHS environment. Works great for me.
ofborg
bot
added
6.topic: printing
8.has: package (new)
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
SuperSandro2000
requested changes
Jan 18, 2021
Comment on lines
+27
to
+28
|
|
||
| phases = [ "installPhase" ]; |
There was a problem hiding this comment.
Suggested change
| phases = [ "installPhase" ]; |
| $out/lib/cups/filter/brother_lpdwrapper_dcpj1100dw | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
This worked for me for a while but I think it's now a bit broken and I haven't had time to fix it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike past Brother drivers, this contains binaries which reference
absolute /opt paths. I could have added an rpath hack to override
syscalls like stat but I decided the driver should just run in a
simple FHS environment. Works great for me.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @