Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions: update 3 #72756

Merged
merged 1 commit into from Nov 4, 2019
Merged

vscode-extensions: update 3 #72756

merged 1 commit into from Nov 4, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Nov 4, 2019 •
edited by jonringer

Just another weekly or bi-monthly? update

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu eadwu requested a review from jonringer as a code owner November 4, 2019 02:24
@eadwu eadwu changed the title vscode-extensions.ms-vscode.cpptools: 0.26.0 -> 0.26.1 vscode-extensions: update 3 Nov 4, 2019
jonringer
jonringer approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected with

[01:43:17] jon@jon-desktop /home/jon/projects/nixpkgs ((37e382e136d...))
$ nix-shell -p "with import ./. {}; vscode-with-extensions.override { vscodeExtensions = with vscode-extensions; [ ms-vscode.cpptools ];}"

@jonringer jonringer merged commit e6bb218 into NixOS:master Nov 4, 2019
@eadwu eadwu deleted the vscode-extensions/update-3 branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @jonringer