Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.03] pythonPackages.koji: 1.13.0 -> 1.14.3 (security) #72797

Merged
merged 2 commits into from Nov 5, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 4, 2019

Motivation for this change

Backport of #72202. Requires marking fedpkg as broken, but it has been broken without this patch since Feb so I don't think it's the end of the world.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ekleog

has been broken in nixpkgs since 2019-02-26 - don't let it stop us
rolling out a security-fixed koji
Addressing CVE-2019-17109

Also added missing description, homepage & license. Re-disabled for py3k
as the kojira executable doesn't seem to be happy with it.

(cherry picked from commit 605a7b3)
@Ekleog
Copy link
Member

Ekleog commented Nov 5, 2019

@ofborg build python27Packages.koji python36Packages.koji

@Ekleog
Copy link
Member

Ekleog commented Nov 5, 2019

BTW, I can confirm, having tried, that fedpkg already fails to build on 19.03, even though it is not marked as broken.

@Ekleog
Copy link
Member

Ekleog commented Nov 5, 2019

Thank you!

@Ekleog Ekleog merged commit a42101e into NixOS:release-19.03 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants