Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensemble-chorus: init at unstable-15-02-2019 #72746

Merged
merged 1 commit into from Nov 16, 2019
Merged

ensemble-chorus: init at unstable-15-02-2019 #72746

merged 1 commit into from Nov 16, 2019

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Nov 3, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@magnetophon
Copy link
Member Author

@marsam One more stuck PR!

@marsam marsam merged commit d83a7f6 into NixOS:master Nov 16, 2019
@magnetophon
Copy link
Member Author

Thanks @marsam!

@magnetophon magnetophon deleted the ensemble-chorus branch November 16, 2019 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @marsam