Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.monty: 1.0.4 -> 3.0.2 #72841

Merged
merged 1 commit into from Nov 22, 2019
Merged

python3Packages.monty: 1.0.4 -> 3.0.2 #72841

merged 1 commit into from Nov 22, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 5, 2019 •
edited

Motivation for this change

noticed it was out of date when reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

could be a slight regression with python2Packages.monty

[4 built (2 failed), 13 copied (9.8 MiB), 1.9 MiB DL]
error: build of '/nix/store/nhqi7qbxa5dkrnxy389qjwfp5483bwjn-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72841
2 package failed to build:
python27Packages.monty python37Packages.sumo

6 package were build:
python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python38Packages.monty

@jonringer jonringer requested a review from FRidh as a code owner November 5, 2019 16:49
@ofborg ofborg bot requested a review from PsyanticY November 5, 2019 17:10
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python38Packages.monty

@jonringer
Copy link
Contributor Author

been 2 weeks, merging

[7 built (2 failed), 116 copied (705.8 MiB), 126.8 MiB DL]
error: build of '/nix/store/qgglydfw6ql9yp9mg4chmcryqgc80zza-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/72841
2 package failed to build:
python27Packages.monty python37Packages.sumo

6 package were built:
python37Packages.dftfit python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python38Packages.monty

@jonringer jonringer merged commit 5191cde into NixOS:master Nov 22, 2019
@jonringer jonringer deleted the bump-monty branch November 22, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer