Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpd: restart always #72770

Merged
merged 1 commit into from Nov 4, 2019
Merged

mpd: restart always #72770

merged 1 commit into from Nov 4, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

@Lassulus reported a crash with his mpd, but systemd did not restart the service.

I guess this fixes it, does it?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Lassulus @makefu @fpletz @ehmry @Fuuzetsu @astsmtl

@matthiasbeyer
mpd: restart always
4e3aa7b 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@fpletz fpletz merged commit e7ef62d into NixOS:master Nov 4, 2019
@matthiasbeyer matthiasbeyer deleted the restart-mpd branch November 4, 2019 12:28
infinisil added a commit to infinisil/system that referenced this pull request Dec 4, 2019
@infinisil
mpd now gets restarted by upstream :)
fc8af22 
NixOS/nixpkgs#72770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @ehmry @fpletz