Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: fix tests #72771

Merged
merged 5 commits into from Nov 6, 2019
Merged

sage: fix tests #72771

merged 5 commits into from Nov 6, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 4, 2019

Motivation for this change

Breakage caused by a breaking change in pkgconfig (updated by 1efa716) and a deprecation warning in attrs (b74344c).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau timokau changed the title sage: fix tests [WIP] sage: fix tests Nov 4, 2019
Needs to be fixed upstream (by werkzeug, twisted). Doesn't impact the
functionality and the tests are soon to be removed with the py3 update
anyway.
python.pkgs.pkgconfig raises an exception on missing packages since
version 1.5.0. Previously those errors were just silently ignored. That
worked fine, since the packages are only missing at runtime (when they
are not really needed) but present at buildtime.

Since this fails the tests now, we just add the packages to
PKG_CONFIG_PATH at runtime. This does not add additional runtime
dependencies. Still, it would be nicer if the sage testssuite would not
test the buildsystem at runtime in the first place.

The breakage was originally caused by the pkgconfig update in
1efa716.
@timokau timokau changed the title [WIP] sage: fix tests sage: fix tests Nov 6, 2019
@timokau
Copy link
Member Author

timokau commented Nov 6, 2019

@GrahamcOfBorg build sage

@timokau timokau merged commit c54848e into NixOS:master Nov 6, 2019
@timokau timokau deleted the sage-fixes branch November 6, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant