Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shogun: switch to using opencv3 #72739

Closed
wants to merge 1 commit into from
Closed

shogun: switch to using opencv3 #72739

wants to merge 1 commit into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 3, 2019

Motivation for this change

opencv 2.x has known, unfixed security vulnerabilities and is reaching EOL.

This builds for me (if I force opencvSupport true of course), but I have no idea if this works correctly and the tests aren't enabled. @edwtjo are you able to test this?

Incidentally I had a go at enabling the tests and it looks like it'll be a bit of fun... after giving cmake the -DENABLE_TESTING=ON flag and setting installCheckPhase to ctest you realize it wants to start downloading copies of googlemock etc...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@risicle
shogun: switch to using opencv3
eeb98c4 
opencv2 has known, unfixed security vulnerabilities
edwtjo added a commit that referenced this pull request Feb 21, 2020
@edwtjo @risicle
shogun: 6.0.0 -> 6.1.4
9b6faed 
Also migrate to opencv3 to address #72739, the PR didn't build for me.
Disable testing and ccache since they were broken.

Co-authored-by: Robert Scott <code@humanleg.org.uk>
@edwtjo
Copy link
Member

edwtjo commented Feb 21, 2020

Addressed in version upgrade at 9b6faed
thanks, and sorry for the delay

@edwtjo edwtjo closed this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @edwtjo