New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: 'Developer Files' section on download pages #111
Conversation
Alas, it is not. As best as I can tell, PDB files are not currently distributed at all (they don't appear in the manifest files at (e.g.) https://proxy.binaries.openttd.org/openttd-releases/1.10.0-beta1/manifest.yaml ) I'm not sure they're even built in the CI currently, you'd need to check yourself - But they're certainly excluded from the manifest generation script - https://github.com/OpenTTD/OpenTTD/blob/2be619ea88837c6293129841511816c105b507a3/azure-pipelines/manifest.sh#L41 |
If I copy the |
Your patch won't do what you think it does :) They are on the ignore list, because people kept downloading them. That is, 30% of the people who downloaded the So I am very much against putting them in the download list, with the other files. History shows that it is a bad solution :) What might work, is some redesigning, where we put this in a new part on the downloads page, something like "Debug files" or what-ever. Here we can list the Either way, if you make a PR for this repository, please create and run the docker to check if it fixes what you think it does :) It is the whole reason this is a Docker .. so you can try it out on your local machine too :P Saves you going back and forth with assumptions :D Going to close this PR for now; as what-ever solution we pick, it should be looking different :D Please do invest time in it, as it is worth fixing this properly! PS: yes, |
Make it a "Tools for developers (not required to play the game)" download section, that also has grfcodec, catcodec, language compiler, etc. |
I like it Perhaps "Developer files" and move sources into it as well? |
Cool :D Should the documentation also be in there? And I guess the dbg-deb files should also be there. I personally wouldn't add the dropdown in the "developers" section, as that is just a bit silly. We use that for binaries, as it autodetects OSes and points people to the right files. No need to do that for developers :D |
Ok removed dropdown, renamed "Debug Files" to "Developer Files". |
Need to add |
Now we have to agree which files to move to the |
Maybe this can go live now :) |
I don't really know how the website works, but I think it would be nice to have an easy access to pdb files. I hope this change is enough.