Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.51.0.72 -> 8.54.0.85 #72850

Merged
merged 1 commit into from Nov 6, 2019
Merged

skypeforlinux: 8.51.0.72 -> 8.54.0.85 #72850

merged 1 commit into from Nov 6, 2019

Conversation

fishi0x01
Copy link
Member

Motivation for this change

Source package got removed https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.51.0.72_amd64.deb

Updated to latest x.y.0.z release, i.e., 8.54.0.85.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @PanAeon @jraygauthier

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 5, 2019

Hello @fishi0x01 and welcome around here since it seems to be your first contribution to nixpkgs :)

As per our contribution guidelines, your commit message should be written like this:
skypeforlinux: 8.51.0.72 -> 8.54.0.85

@ofborg ofborg bot requested a review from jraygauthier November 5, 2019 18:23
@fishi0x01
Copy link
Member Author

Thanks for pointing this out @c0bw3b 🙇‍♂️
I will read the guideline more thoroughly 👍

I adjusted the commit message as you suggested :)

@fishi0x01 fishi0x01 changed the title Upgrade skypeforlinux to 8.54.0.85 skypeforlinux: 8.51.0.72 -> 8.54.0.85 Nov 6, 2019
c0bw3b
c0bw3b approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it locally on x64 NixOS and it runs as expected.

@c0bw3b c0bw3b merged commit c59079b into NixOS:master Nov 6, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 6, 2019

Thank you @fishi0x01 for this update. 🚀

@fishi0x01 fishi0x01 deleted the fishi0x01/skype-upgrade branch November 6, 2019 13:20
@d-goldin
Copy link
Contributor

I think this could be a candidate for backporting to 19.09, as currently this seems broken. I think in such a case a version upgrade of such a leaf package is probably legitimate for the stable release.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2019

It was updated in #72822 for r19.09
Is v8.51.0.86 not working ?

@d-goldin
Copy link
Contributor

@c0bw3b: It does not exist anymore: https://repo.skype.com/deb/pool/main/s/skypeforlinux/

> git rev-parse HEAD                                                                                  
c0c062da7b3e20ec3b6c9416bc03cb3fc61df4b8

> nix-build -I nixpkgs=$(pwd) '<nixpkgs>' -A pkgs.skypeforlinux                                             release-19.09 [c0c062da7b3] untracked

these derivations will be built:
  /nix/store/f8gyiby845s8wxlwy37dfbyiyz622gv9-skypeforlinux_8.51.0.86_amd64.deb.drv
  /nix/store/c1yan6hs2clfhrcg6w7vkjqhikg91mgl-skypeforlinux-8.51.0.86.drv
building '/nix/store/f8gyiby845s8wxlwy37dfbyiyz622gv9-skypeforlinux_8.51.0.86_amd64.deb.drv'...

trying https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_8.51.0.86_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download skypeforlinux_8.51.0.86_amd64.deb from any mirror
builder for '/nix/store/f8gyiby845s8wxlwy37dfbyiyz622gv9-skypeforlinux_8.51.0.86_amd64.deb.drv' failed with exit code 1
cannot build derivation '/nix/store/c1yan6hs2clfhrcg6w7vkjqhikg91mgl-skypeforlinux-8.51.0.86.drv': 1 dependencies couldn't be built
error: build of '/nix/store/c1yan6hs2clfhrcg6w7vkjqhikg91mgl-skypeforlinux-8.51.0.86.drv' failed

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 18, 2019

Quick fix in e6d584f

Wish upstream repo would be more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@jraygauthier jraygauthier Awaiting requested review from jraygauthier

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fishi0x01 @c0bw3b @d-goldin @Janik-Haag