Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] python3Packages.pycairo: 1.18.1 -> 1.18.2 #72849

Merged
merged 1 commit into from Nov 12, 2019
Merged

[staging] python3Packages.pycairo: 1.18.1 -> 1.18.2 #72849

merged 1 commit into from Nov 12, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 5, 2019 •
edited

Motivation for this change

looking through @r-ryantm logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner November 5, 2019 17:41
@worldofpeace worldofpeace self-assigned this Nov 5, 2019
@FRidh FRidh added this to Needs review in Staging Nov 12, 2019
@FRidh
Copy link
Member

FRidh commented Nov 12, 2019

@worldofpeace anything you want to test?

@worldofpeace
Copy link
Contributor

@FRidh Yep, will do this shortly as I have the time. Thanks for the reminder 👍

worldofpeace
worldofpeace approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://pycairo.readthedocs.io/en/latest/changelog.html#v1-18-2, fixes stuff with python 3.8.

Staging automation moved this from Needs review to Ready Nov 12, 2019
@worldofpeace worldofpeace merged commit 7f4dcce into NixOS:staging Nov 12, 2019
Staging automation moved this from Ready to Done Nov 12, 2019
@jonringer jonringer deleted the bump-pycairo branch November 12, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@worldofpeace worldofpeace

Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @FRidh @worldofpeace