Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gjs: various improvements #72805

Merged
merged 3 commits into from Nov 5, 2019
Merged

gjs: various improvements #72805

merged 3 commits into from Nov 5, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 5, 2019

  • Move to top-level
  • Clean up the expression
  • Try to build on Darwin

@worldofpeace
Copy link
Contributor

worldofpeace commented Nov 5, 2019

Fails to evaluate on darwin because spidermonkey_60 doesn't.

@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 5, 2019

Bah, it wants to execute xcode-select --print-path. Let’s just not build GIMP with JavaScript support on Darwin.

@jtojnar jtojnar merged commit 9d36ef7 into NixOS:master Nov 5, 2019
@jtojnar jtojnar deleted the gjs-improvement branch November 5, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants