Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facetimehd-firmware: 1.43_4 -> 1.43_5 #72804

Merged
merged 1 commit into from Nov 9, 2019
Merged

facetimehd-firmware: 1.43_4 -> 1.43_5 #72804

merged 1 commit into from Nov 9, 2019

Conversation

offlinehacker
Copy link
Contributor

@offlinehacker offlinehacker commented Nov 4, 2019 •
edited

Motivation for this change

Fixes: #71952
Fix NixOS kernel as it does not build due missing firmware link. I can't be sure if offsets of firmware inside file are correct (i'm sure downloaded ranges are correct) as i cannot test as i do not have required hardware, but i guess it should do the trick.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @womfoo @grahamc

@offlinehacker offlinehacker mentioned this pull request Nov 4, 2019
Closed
@offlinehacker offlinehacker force-pushed the pkgs/facetimehd-firmware/update-firmware-link branch from 1d32292 to c115659 Compare November 4, 2019 23:37
@offlinehacker
Copy link
Contributor Author

See also: patjak/facetimehd-firmware#1

@ofborg ofborg bot requested review from grahamc and womfoo November 4, 2019 23:49
veprbl
veprbl approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review (x86_64-linux, NixOS)

1 package were build:
facetimehd-firmware

@offlinehacker
Copy link
Contributor Author

Should be fine since it produces firmware with same checksum, didn't noticed it before: https://github.com/patjak/facetimehd-firmware/pull/2/files#diff-634903fbf2f39c35200155b6e130caacR22

womfoo
womfoo approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@womfoo womfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK on my MacBookPro11,3 running nixos-unstable. This also needs to be backported to 19.09.

Thanks for looking into this @offlinehacker!

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 6, 2019
arcnmx added a commit to arcnmx/nixexprs that referenced this pull request Nov 8, 2019
@arcnmx
workaround broken pkgs.facetimehd-firmware
feb7124 
Until NixOS/nixpkgs#72804 is merged.
@veprbl veprbl merged commit 21c3fab into NixOS:master Nov 9, 2019
@thpham
Copy link
Member

thpham commented Nov 9, 2019

LGTM, I tested on My MBP 15 (2015) and it works.

@alexeymuranov
Copy link
Contributor

Still needs to be ported to stable, i suppose...

veprbl pushed a commit that referenced this pull request Nov 10, 2019
@offlinehacker @veprbl
facetimehd-firmware: 1.43_4 -> 1.43_5
32dfdb0 
(cherry picked from commit c115659)

cc #72804
veprbl pushed a commit that referenced this pull request Nov 10, 2019
@offlinehacker @veprbl
facetimehd-firmware: 1.43_4 -> 1.43_5
6c08aa0 
(cherry picked from commit c115659)

cc #72804
@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 10, 2019
@matthewbauer matthewbauer mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thpham thpham thpham left review comments

@veprbl veprbl veprbl approved these changes

@womfoo womfoo womfoo approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

facetimehd-firmware can't be built: url for osxupd10.11.5.dmg returns 404
5 participants
@offlinehacker @thpham @alexeymuranov @veprbl @womfoo