Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.librosa: add missing dependency #72842

Merged
merged 1 commit into from Nov 13, 2019
Merged

python3Packages.librosa: add missing dependency #72842

merged 1 commit into from Nov 13, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 5, 2019 •
edited

Motivation for this change

noticed it was broken while reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[3 built, 9 copied (39.1 MiB), 9.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72842
3 package were build:
python27Packages.librosa python37Packages.librosa python38Packages.librosa

@jonringer jonringer requested a review from FRidh as a code owner November 5, 2019 17:02
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python27Packages.librosa python37Packages.librosa python38Packages.librosa

@c0bw3b c0bw3b changed the title python3Packages.librosa: add missing depenency python3Packages.librosa: add missing dependency Nov 13, 2019
c0bw3b
c0bw3b approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLAlchemy failure on Darwin with Py38 is not a regression (previously failing on Hydra)

@c0bw3b c0bw3b merged commit 529f030 into NixOS:master Nov 13, 2019
@jonringer jonringer deleted the fix-librosa branch November 13, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @c0bw3b