Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ansible: 2.8.4 -> 2.9.2 #72844

Merged
merged 3 commits into from Jan 22, 2020
Merged

python3Packages.ansible: 2.8.4 -> 2.9.2 #72844

merged 3 commits into from Jan 22, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 5, 2019 •
edited

Motivation for this change

noticed @r-ryantm couldn't update it

closes #70326

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

failures are broken on master

[3 built, 1 copied (10.2 MiB), 10.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72844
3 package were built:
ansible ansible_2_6 ansible_2_7

@jonringer jonringer requested a review from FRidh as a code owner November 5, 2019 17:21
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build ansible kargo python27Packages.ansible python27Packages.ansible-runner python27Packages.pytest-ansible python37Packages.ansible-kernel python37Packages.ansible-runner python37Packages.pytest-ansible python38Packages.ansible python38Packages.ansible-kernel python38Packages.ansible-runner python38Packages.pytest-ansible

@ofborg ofborg bot requested a review from costrouc November 5, 2019 17:36
c0bw3b
c0bw3b previously requested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful here, Ansible minor versions introduce breaking changes and require some porting.
That's why we have ansible_2_6, ansible_2_7 and ansible = Ansible 2.8

OTOH there is a v2.8.6 available and it contains CVE fixes too. So it should probably be updated to that version and backported.
+ same CVE fixes in v2.6.20 and v2.7.14

@jonringer
Copy link
Contributor Author

i could freeze the ansible package to 2.8, but what i mean to change was just the python package.

@jonringer
Copy link
Contributor Author

why would ansible release a minor version with breaking changes....

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 5, 2019 •
edited

Han >;< it's getting too late for me, just saw "ansible: 2.8.x -> 2.9" and thought woops
But I guess the Py package works best with the corresponding Ansible minor version.

why would ansible release a minor version with breaking changes....

IKR! It's quite painful to work with.. :/

@c0bw3b c0bw3b dismissed their stale review November 5, 2019 23:34

Irrelevant

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 5, 2019

Ah still we define:

  ansible_2_8 = with python3Packages; toPythonApplication ansible;

So this bump would actually bump ansible_2_8 to 2.9.0

@jonringer
Copy link
Contributor Author

yea, I will freeze the current version, and just add an ansible_2_9 entry, then people can opt into it.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 6, 2019

Yes it's the most practical way.

@jonringer
Copy link
Contributor Author

wondering if i should break this out into two commits, one for freezing, then one for the bump. But I made it so that ansible and ansible_2_8 reference 2_8, and now the python package is at the latest

@jonringer
Copy link
Contributor Author

actually, I bumped ansibled from 2.8.4 to 2.8.6, i should do a separate commit....

@jonringer jonringer mentioned this pull request Nov 11, 2019
Closed
10 tasks
Lassulus
Lassulus reviewed Dec 8, 2019
View reviewed changes
pkgs/tools/admin/ansible/default.nix Outdated

ansible_2_8 = with python3Packages; toPythonApplication ansible;
ansible = with python3Packages; toPythonApplication (ansible.overridePythonAttrs(old: rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we use an recursive attribute-set and say ansible = ansible_2_8; ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump @jonringer

@jonringer jonringer force-pushed the bump-ansible branch 2 times, most recently from a083ee4 to 120c122 Compare January 9, 2020 20:00
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build ansible ansible_2_6 ansible_2_7 ansible_2_9

@jonringer jonringer requested a review from c0bw3b January 9, 2020 20:36
@jonringer jonringer changed the title python3Packages.ansible: 2.8.4 -> 2.9.0 python3Packages.ansible: 2.8.4 -> 2.9.2 Jan 9, 2020
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build ansible ansible_2_6 ansible_2_7 ansible_2_9

@jonringer
Copy link
Contributor Author

interesting.... darwin is getting different sha's

@jonringer
Copy link
Contributor Author

cc @infinisil would you know why darwin is getting different hashes on a .tar.gz?

@jonringer
Copy link
Contributor Author

this is just for ansible_2_9, which means ansible still works on darwin. I might just push :/

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build ansible_2_9

@infinisil
Copy link
Member

The only thing I can think of is filepath unicode normalization, which certain filesystems on macOS do

@jonringer jonringer merged commit 1474940 into NixOS:master Jan 22, 2020
@jonringer jonringer deleted the bump-ansible branch January 22, 2020 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @c0bw3b @infinisil @Lassulus @JohnAZoidberg