update most packages I maintain #72020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
let me know when you're done adding packages, and then I'll review :) |
|
@jonringer Done 😄 |
jonringer
reviewed
Oct 26, 2019
jonringer
reviewed
Nov 1, 2019
|
@jonringer All is done. Thanks for suggestions! |
added 10 commits
November 4, 2019 10:04
Became incorrect after #66585
|
next time, I would just group these into related packages, and do a PR per group. Harder to review when a lot is going on :) |
jonringer
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
nix-review passes on NixOS
diff LGTM
no regressions
most packages with executables at least display --help
[29 built, 173 copied (912.2 MiB), 211.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/72020
18 package were build:
gnome3.gnome-boxes kmsxx openjk openmw-tes3mp openxray pakcs phodav python27Packages.kmsxx python37Packages.kmsxx python38Packages.kmsxx remmina spice-gtk video2midi virt-manager virt-manager-qt virt-viewer vk-messenger vkquake
|
@jonringer Thank you! |
Got it, ok 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Test with
nix-review pr 72020Few packages were already bumped by other people
openmpt123 #71080
franz #71862
ps_mem #72611
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @