Fix c02ef3e456: Special case of Var 0x88 was not handled for NRT Acti… #7823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's a bit unclear why there are 4 condition types for NRT checks, seems 2 would be enough |
…hecks from Action 7
LordAro
previously approved these changes
Nov 3, 2019
frosch123
requested changes
Nov 3, 2019
| @@ -6630,10 +6632,6 @@ static void SkipIf(ByteReader *buf) | |||
| break; | |||
| case 0x10: result = GetRoadTypeByLabel(BSWAP32(cond_val)) != INVALID_ROADTYPE; | |||
| break; | |||
| case 0x11: result = GetRoadTypeByLabel(BSWAP32(cond_val)) == INVALID_ROADTYPE; | |||
| break; | |||
There was a problem hiding this comment.
I think this stuff is correct and should be kept.
There are also separate translation tables for road and tram.
But who knows.
There was a problem hiding this comment.
If they should be kept as a separation between Road and Tram, they should probably be extended with actually different checks.
TrueBrain
added
candidate: needs considering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on 7 conditions