Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python: pg8000: 1.12.5 -> 1.13.2" #72721

Merged
merged 1 commit into from Nov 3, 2019
Merged

Revert "python: pg8000: 1.12.5 -> 1.13.2" #72721

merged 1 commit into from Nov 3, 2019

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Nov 3, 2019

This reverts commit 35bdea0.

The package: pkgs/development/python-modules/pg8000/1_12.nix is intended to be frozen at 1.12.x and this bump was breaking due to 1.13 not being python2 compatible.

I think this was done automatically, but perhaps this one could be black-listed from updates?

Motivation for this change

The package doesn't build and breaks the service datadog-agent.

Things done

Reverted the commit and verified that the broken package builds.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@prusnak
Copy link
Member

prusnak commented Nov 3, 2019 •
edited

I read somewhere that the auto-update bot will not touch the files when a filename is a substring of the version. That's in your case if the file was named 1.12.nix instead of 1_12.nix the bot would not touch it.

@FRidh FRidh merged commit 9a4ae42 into NixOS:master Nov 3, 2019
@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

This was done not by the @r-ryantm bot, but by my maintainers/scripts/update-python-libraries script.

@FRidh
Copy link
Member

FRidh commented Nov 3, 2019 •
edited

In the future I will invoke it as maintainers/scripts/update-python-libraries pkgs/development/python-modules/**/default.nix instead so as not to touch the pinned versions.

If I don't forget that is...

@ofborg ofborg bot requested a review from domenkozar November 3, 2019 15:49
@terlar terlar deleted the fix-pg8000_1_12 branch November 3, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terlar @prusnak @FRidh