Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signal-cli: enable dbus functionality #72829

Merged
merged 2 commits into from Nov 18, 2019
Merged

signal-cli: enable dbus functionality #72829

merged 2 commits into from Nov 18, 2019

Conversation

erictapen
Copy link
Member

Motivation for this change

Close #72737

Things done

Refined the code from #72737 (comment).

Now the following should work:

# Starting the daemon
./result/bin/signal-cli -u MY_NUMBER daemon

# Sending messages while the daemon is running
./result/bin/signal-cli --dbus send -m "test message" RECIPIENT_NUMBER
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ivan

@erictapen
Copy link
Member Author

@GrahamcOfBorg build signal-cli

@ofborg ofborg bot requested a review from ivan November 5, 2019 13:07
ivan
ivan approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine and I confirmed that it works, at least after I set DBUS_SESSION_BUS_ADDRESS (not present in my SSH session).

Since you're using and maintaining this more than I am, would you also like to add yourself or a co-author as a maintainer?

@erictapen
Copy link
Member Author

Since you're using and maintaining this more than I am, would you also like to add yourself or a co-author as a maintainer?

Sure!

@ofborg ofborg bot requested a review from ivan November 5, 2019 14:07
ivan
ivan suggested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just noticed that dbus_java and libmatthew_java are Linux-only, it would be good to keep this working on darwin in the spirit of not breaking things that worked previously.

@erictapen
Copy link
Member Author

Personally I don't think I'd need to fix the breakage for darwin, as

  • we don't know wether anyone on darwin actually uses this
  • I don't have the tools to test wether this actually builds on darwin.

But as this one is cheap I added some extra logic that hopefully enables the darwin package to still build.

@ofborg ofborg bot requested a review from ivan November 7, 2019 16:42
@Mic92
Copy link
Member

Mic92 commented Nov 7, 2019

@GrahamcOfBorg build signal-cli

erictapen and others added 2 commits November 7, 2019 21:25
@erictapen @matthew-piziak @Kiwi
signal-cli: add dbus functionality
6d6fee5 
This closes NixOS#72737

Co-authored-by: Matthew Piziak <matthew-piziak@users.noreply.github.com>
Co-authored-by: Kiwi <Kiwi@users.noreply.github.com>
@erictapen
signal-cli: add erictapen as maintainer
a39fbee
@erictapen
Copy link
Member Author

@GrahamcOfBorg build signal-cli

ivan
ivan approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks fine and I confirmed that it still builds on macOS 10.14.

0x4A6F
0x4A6F approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so with a slightly modified #72948 (with jwoglom/npyscreen@d01ce55) signal-ncurses can utilize signal-cli.

@erictapen
Copy link
Member Author

So anybody wants to merge this? I guess this is low hanging fruit, as it got approved by two people.

@Lassulus Lassulus merged commit 505120a into NixOS:master Nov 18, 2019
@johnfreed johnfreed mentioned this pull request Oct 6, 2021
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packaging-help-with-dbus-for-intune/24591/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@ivan ivan ivan approved these changes

@0x4A6F 0x4A6F 0x4A6F approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

signal-cli daemon not supported
6 participants
@erictapen @Mic92 @nixos-discourse @ivan @0x4A6F @Lassulus