Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-okta: 0.20.1 -> 0.26.3 #72761

Merged
merged 1 commit into from
Jan 4, 2020
Merged

aws-okta: 0.20.1 -> 0.26.3 #72761

merged 1 commit into from
Jan 4, 2020
+2 −2

Conversation

Charg
Copy link
Contributor

@Charg Charg commented Nov 4, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@Charg
aws-okta: 0.20.1 -> 0.26.3

Verified

This commit was signed with the committer’s verified signature.
sikmir Nikolay Korotkiy
GPG key ID: D1DE6D7F693663A5
Verified
Learn about vigilant mode
e6ccc08
@ofborg ofborg bot requested review from imalsogreg and ehmry November 4, 2019 05:12
@imalsogreg
Copy link
Contributor

I no longer have an okta account to use for testing. Would you mind describing what testing has been done?

@Charg
Copy link
Contributor Author

Charg commented Dec 6, 2019

@imalsogreg I've been using this in my environment for the past month. I'm running nix on ubuntu 18.04. So far, no issues.

imalsogreg
imalsogreg approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@imalsogreg imalsogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authors says they've tested locally. Looks good to me!

@kalbasit kalbasit merged commit 6f43c82 into NixOS:master Jan 4, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@Charg @dtzWill
aws-okta: 0.20.1 -> 0.26.3 (NixOS#72761)
ff30468 
(cherry picked from commit 6f43c82)
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit

@ehmry ehmry

@imalsogreg imalsogreg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Charg @imalsogreg @kalbasit @ehmry @Janik-Haag